From: David Chinner <dgc@sgi.com>
To: xfs-masters@oss.sgi.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, reiserfs-dev@namesys.com
Subject: Re: [xfs-masters] Re: [PATCH] Cleanup and kernelify shrinker registration (rc5-mm2)
Date: Tue, 3 Apr 2007 22:37:06 +1000 [thread overview]
Message-ID: <20070403123706.GX32597093@melbourne.sgi.com> (raw)
In-Reply-To: <1175584705.12230.513.camel@localhost.localdomain>
On Tue, Apr 03, 2007 at 05:18:25PM +1000, Rusty Russell wrote:
> On Mon, 2007-04-02 at 23:09 -0700, Andrew Morton wrote:
> This is not about efficiency. When have I *ever* posted optimization
> patches?
>
> This is about clarity. We have a standard convention for
> register/unregister. And they can't fail. Either of these would be
> sufficient to justify a change.
>
> Too many people doing cool new things in the kernel, not enough
> polishing of the crap that's already there 8(
>
> > But I think we need to weed that crappiness out of XFS first.
Can anyone else see the contradiction in these statements?
XFS's "crappiness" is a register/unregister interface. The only
reason it's being removed is because it's getting replaced with a
nearly identical register/unregister interface.
Just thought I'd point that out.... ;)
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-03 12:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 3:44 Rusty Russell
2007-04-03 3:47 ` Rusty Russell
2007-04-03 3:58 ` Andrew Morton
2007-04-03 4:45 ` Rusty Russell
2007-04-03 4:57 ` Andrew Morton
2007-04-03 5:44 ` [xfs-masters] " David Chinner
2007-04-03 6:01 ` Andrew Morton
2007-04-03 6:19 ` David Chinner
2007-04-04 0:30 ` Rusty Russell
2007-04-03 5:47 ` Rusty Russell
2007-04-03 6:09 ` Andrew Morton
2007-04-03 7:18 ` Rusty Russell
2007-04-03 12:37 ` David Chinner [this message]
2007-04-03 17:36 ` [xfs-masters] " Andrew Morton
2007-04-04 0:03 ` David Chinner
2007-04-03 9:57 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070403123706.GX32597093@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=reiserfs-dev@namesys.com \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox