* [KJ] [PATCH] mm: spelling error in a comment
@ 2007-04-02 21:06 Charles Clément
2007-04-02 22:27 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Charles Clément @ 2007-04-02 21:06 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-mm
Fix spelling in a comment in mm/slab.c.
Signed-off-by: Charles Clement <caratorn@gmail.com>
---
Index: linux-2.6.21-rc5/mm/slab.c
===================================================================
--- linux-2.6.21-rc5.orig/mm/slab.c
+++ linux-2.6.21-rc5/mm/slab.c
@@ -451,7 +451,7 @@ struct kmem_cache {
#define BATCHREFILL_LIMIT 16
/*
- * Optimization question: fewer reaps means less probability for unnessary
+ * Optimization question: fewer reaps means less probability for unnecessary
* cpucache drain/refill cycles.
*
* OTOH the cpuarrays can contain lots of objects,
--
Charles Clement.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [KJ] [PATCH] mm: spelling error in a comment
2007-04-02 21:06 [KJ] [PATCH] mm: spelling error in a comment Charles Clément
@ 2007-04-02 22:27 ` Randy Dunlap
2007-04-02 22:58 ` Richard Knutsson
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2007-04-02 22:27 UTC (permalink / raw)
To: Charles Clément; +Cc: kernel-janitors, linux-mm
On Mon, 2 Apr 2007 23:06:36 +0200 Charles Clement wrote:
>
> Fix spelling in a comment in mm/slab.c.
>
> Signed-off-by: Charles Clement <caratorn@gmail.com>
Alexey can grab this if he wants to (or Adrian could),
but here's what Andrew Morton has to say about such patches:
http://marc.info/?l=kernel-janitor-discuss&m=117360826232574&w=2
"...I prefer not to do spello and grammaro
fixes, unless they're in something user-visible: a printk or documentation.
Simply because there would be no end to it."
> ---
>
> Index: linux-2.6.21-rc5/mm/slab.c
> ===================================================================
> --- linux-2.6.21-rc5.orig/mm/slab.c
> +++ linux-2.6.21-rc5/mm/slab.c
> @@ -451,7 +451,7 @@ struct kmem_cache {
>
> #define BATCHREFILL_LIMIT 16
> /*
> - * Optimization question: fewer reaps means less probability for unnessary
> + * Optimization question: fewer reaps means less probability for unnecessary
> * cpucache drain/refill cycles.
> *
> * OTOH the cpuarrays can contain lots of objects,
>
> --
> Charles Clement.
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
>
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [KJ] [PATCH] mm: spelling error in a comment
2007-04-02 22:27 ` Randy Dunlap
@ 2007-04-02 22:58 ` Richard Knutsson
2007-04-03 10:02 ` Charles Clément
0 siblings, 1 reply; 5+ messages in thread
From: Richard Knutsson @ 2007-04-02 22:58 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Charles Clément, linux-mm, kernel-janitors
Randy Dunlap wrote:
> On Mon, 2 Apr 2007 23:06:36 +0200 Charles Clement wrote:
>
>
>> Fix spelling in a comment in mm/slab.c.
>>
>> Signed-off-by: Charles Clement <caratorn@gmail.com>
>>
>
> Alexey can grab this if he wants to (or Adrian could),
> but here's what Andrew Morton has to say about such patches:
>
> http://marc.info/?l=kernel-janitor-discuss&m=117360826232574&w=2
>
> "...I prefer not to do spello and grammaro
> fixes, unless they're in something user-visible: a printk or documentation.
> Simply because there would be no end to it."
>
>
Also, regardless if it is a comment or not, I think it may be a good
idea to put such uncommon mistakes in KJ's wiki under "Spelling
mistakes" and let it all be taken care of once in a while.
(http://fsdev.net/wiki/index.php?title=Spelling_mistakes)
Richard Knutsson
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [KJ] [PATCH] mm: spelling error in a comment
2007-04-02 22:58 ` Richard Knutsson
@ 2007-04-03 10:02 ` Charles Clément
0 siblings, 0 replies; 5+ messages in thread
From: Charles Clément @ 2007-04-03 10:02 UTC (permalink / raw)
To: Richard Knutsson
Cc: Randy Dunlap, Charles Clément, linux-mm, kernel-janitors
On Tue, Apr 03, 2007 at 12:58:24AM +0200, Richard Knutsson wrote:
> Randy Dunlap wrote:
> >On Mon, 2 Apr 2007 23:06:36 +0200 Charles Clement wrote:
> >>Fix spelling in a comment in mm/slab.c.
> >>
> >>Signed-off-by: Charles Clement <caratorn@gmail.com>
> >>
> >"...I prefer not to do spello and grammaro
> >fixes, unless they're in something user-visible: a printk or documentation.
> >Simply because there would be no end to it."
Ok, I didn't know that, thank you.
> Also, regardless if it is a comment or not, I think it may be a good
> idea to put such uncommon mistakes in KJ's wiki under "Spelling
> mistakes" and let it all be taken care of once in a while.
> (http://fsdev.net/wiki/index.php?title=Spelling_mistakes)
>
> Richard Knutsson
Yes, I agree with that but it then should be accessible, as with a
patchset. Or maybe the solution to this is simply to send them to the trivial
patch adress.
--
Charles Clement.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [KJ] [PATCH] mm: spelling error in a comment
@ 2007-04-02 14:51 Charles Clément
0 siblings, 0 replies; 5+ messages in thread
From: Charles Clément @ 2007-04-02 14:51 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-mm
Spelling fix in a comment in mm/slab.c.
Signed-off-by: Charles Clement <caratorn@gmail.com>
---
Index: linux-2.6.21-rc5/mm/slab.c
===================================================================
--- linux-2.6.21-rc5.orig/mm/slab.c
+++ linux-2.6.21-rc5/mm/slab.c
@@ -451,7 +451,7 @@ struct kmem_cache {
#define BATCHREFILL_LIMIT 16
/*
- * Optimization question: fewer reaps means less probability for unnessary
+ * Optimization question: fewer reaps means less probability for unnecessary
* cpucache drain/refill cycles.
*
* OTOH the cpuarrays can contain lots of objects,
--
Charles Clement.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-04-03 10:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-02 21:06 [KJ] [PATCH] mm: spelling error in a comment Charles Clément
2007-04-02 22:27 ` Randy Dunlap
2007-04-02 22:58 ` Richard Knutsson
2007-04-03 10:02 ` Charles Clément
-- strict thread matches above, loose matches on Subject: below --
2007-04-02 14:51 Charles Clément
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox