From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 26 Mar 2007 10:26:51 -0800 From: Andrew Morton Subject: Re: [QUICKLIST 1/5] Quicklists for page table pages V4 Message-Id: <20070326102651.6d59207b.akpm@linux-foundation.org> In-Reply-To: References: <20070323062843.19502.19827.sendpatchset@schroedinger.engr.sgi.com> <20070322223927.bb4caf43.akpm@linux-foundation.org> <20070322234848.100abb3d.akpm@linux-foundation.org> <20070323222133.f17090cf.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Mon, 26 Mar 2007 09:52:17 -0700 (PDT) Christoph Lameter wrote: > On Fri, 23 Mar 2007, Andrew Morton wrote: > > > On Fri, 23 Mar 2007 10:54:12 -0700 (PDT) Christoph Lameter wrote: > > > > > Here are the results of aim9 tests on x86_64. There are some minor performance > > > improvements and some fluctuations. > > > > There are a lot of numbers there - what do they tell us? > > That there are performance improvements because of quicklists. Christoph, you can continue to be obtuse, and I can continue to ignore these patches until a) it has been demonstrated that this patch is superior to simply removing the quicklists and b) we understand why the below simple modification crashes i386. diff -puN include/linux/quicklist.h~qlhack include/linux/quicklist.h --- a/include/linux/quicklist.h~qlhack +++ a/include/linux/quicklist.h @@ -32,45 +32,17 @@ DECLARE_PER_CPU(struct quicklist, quickl */ static inline void *quicklist_alloc(int nr, gfp_t flags, void (*ctor)(void *)) { - struct quicklist *q; - void **p = NULL; - - q =&get_cpu_var(quicklist)[nr]; - p = q->page; - if (likely(p)) { - q->page = p[0]; - p[0] = NULL; - q->nr_pages--; - } - put_cpu_var(quicklist); - if (likely(p)) - return p; - - p = (void *)__get_free_page(flags | __GFP_ZERO); + void *p = (void *)__get_free_page(flags | __GFP_ZERO); if (ctor && p) ctor(p); return p; } -static inline void quicklist_free(int nr, void (*dtor)(void *), void *pp) +static inline void quicklist_free(int nr, void (*dtor)(void *), void *p) { - struct quicklist *q; - void **p = pp; - struct page *page = virt_to_page(p); - int nid = page_to_nid(page); - - if (unlikely(nid != numa_node_id())) { - if (dtor) - dtor(p); - free_page((unsigned long)p); - return; - } - - q = &get_cpu_var(quicklist)[nr]; - p[0] = q->page; - q->page = p; - q->nr_pages++; - put_cpu_var(quicklist); + if (dtor) + dtor(p); + free_page((unsigned long)p); } void quicklist_trim(int nr, void (*dtor)(void *), @@ -81,4 +53,3 @@ unsigned long quicklist_total_size(void) #endif #endif /* LINUX_QUICKLIST_H */ - _ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org