From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 20 Mar 2007 20:07:19 -0500 From: Matt Mackall Subject: Re: [RFC][PATCH] split file and anonymous page queues #3 Message-ID: <20070321010719.GM10459@waste.org> References: <46005B4A.6050307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46005B4A.6050307@redhat.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel Cc: Linux Kernel Mailing List , linux-mm List-ID: On Tue, Mar 20, 2007 at 06:08:10PM -0400, Rik van Riel wrote: > - "Active: %8lu kB\n" > - "Inactive: %8lu kB\n" ... > + "Active(anon): %8lu kB\n" > + "Inactive(anon): %8lu kB\n" > + "Active(file): %8lu kB\n" > + "Inactive(file): %8lu kB\n" Potentially incompatible change. How about preserving the original fields (by totalling), then adding the other fields in a second patch. > if (!pagevec_add(&lru_pvec, page)) > - __pagevec_lru_add(&lru_pvec); > + __pagevec_lru_add_file(&lru_pvec); Wouldn't lru_file_add or file_lru_add be a better name? If the object is a "file lru" then sticking "add" in the middle is a little ugly. > spin_lock_irq(&zone->lru_lock); > if (PageLRU(page) && !PageActive(page)) { > - del_page_from_inactive_list(zone, page); > + if (page_anon(page)) { > + del_page_from_inactive_anon_list(zone,page); > SetPageActive(page); > - add_page_to_active_list(zone, page); > + add_page_to_active_anon_list(zone, page); > + } else { > + del_page_from_inactive_file_list(zone, page); > + SetPageActive(page); > + add_page_to_active_file_list(zone, page); > + } > __count_vm_event(PGACTIVATE); > } Missing a level of indentation. -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org