From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 16 Mar 2007 09:20:34 -0500 From: Anton Blanchard Subject: Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed Message-ID: <20070316142034.GA5962@kryten> References: <20070312142012.GH30777@atrey.karlin.mff.cuni.cz> <20070312143900.GB6016@wotan.suse.de> <20070312151355.GB23532@duck.suse.cz> <20070312173500.GF23532@duck.suse.cz> <20070313185554.GA5105@duck.suse.cz> <1173905741.8763.36.camel@kleikamp.austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1173905741.8763.36.camel@kleikamp.austin.ibm.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Dave Kleikamp Cc: Ashif Harji , linux-mm@kvack.org, Nick Piggin , Jan Kara , linux-kernel@vger.kernel.org, akpm@linux-foundation.org List-ID: Hi, > I guess the downside to this is if a reader is reading a large file, or > several files, sequentially with a small read size (smaller than > PAGE_SIZE), the pages will be marked active after just one read pass. > My gut says the benefits of this patch outweigh the cost. I would > expect real-world backup apps, etc. to read at least PAGE_SIZE. PAGE_SIZE being 8k on sparc, 16-64k on ia64 and potentially 64kb on powerpc :) Id expect a large percentage of files to be below that size. Anton -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org