* [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable
@ 2007-03-15 13:49 Ankita Garg
2007-03-15 13:52 ` Nick Piggin
2007-03-15 22:22 ` William Lee Irwin III
0 siblings, 2 replies; 3+ messages in thread
From: Ankita Garg @ 2007-03-15 13:49 UTC (permalink / raw)
To: Linux Memory Management; +Cc: LKML, Nick Piggin, Andrew Morton
Looking at oom_kill.c, found that the intention to not kill the selected
process if any of its children/siblings has OOM_DISABLE set, is not being met.
Signed-off-by: Ankita Garg <ankita@in.ibm.com>
Index: ankita/linux-2.6.20.1/mm/oom_kill.c
===================================================================
--- ankita.orig/linux-2.6.20.1/mm/oom_kill.c 2007-02-20 12:04:32.000000000 +0530
+++ ankita/linux-2.6.20.1/mm/oom_kill.c 2007-03-15 12:44:50.000000000 +0530
@@ -320,7 +320,7 @@
* Don't kill the process if any threads are set to OOM_DISABLE
*/
do_each_thread(g, q) {
- if (q->mm == mm && p->oomkilladj == OOM_DISABLE)
+ if (q->mm == mm && q->oomkilladj == OOM_DISABLE)
return 1;
} while_each_thread(g, q);
Regards,
--
Ankita Garg (ankita@in.ibm.com)
Linux Technology Center
IBM India Systems & Technology Labs,
Bangalore, India
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable
2007-03-15 13:49 [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable Ankita Garg
@ 2007-03-15 13:52 ` Nick Piggin
2007-03-15 22:22 ` William Lee Irwin III
1 sibling, 0 replies; 3+ messages in thread
From: Nick Piggin @ 2007-03-15 13:52 UTC (permalink / raw)
To: Ankita Garg; +Cc: Linux Memory Management, LKML, Andrew Morton
On Thu, Mar 15, 2007 at 07:19:21PM +0530, Ankita Garg wrote:
>
> Looking at oom_kill.c, found that the intention to not kill the selected
> process if any of its children/siblings has OOM_DISABLE set, is not being met.
>
>
> Signed-off-by: Ankita Garg <ankita@in.ibm.com>
Acked-by: Nick Piggin <npiggin@suse.de>
>
> Index: ankita/linux-2.6.20.1/mm/oom_kill.c
> ===================================================================
> --- ankita.orig/linux-2.6.20.1/mm/oom_kill.c 2007-02-20 12:04:32.000000000 +0530
> +++ ankita/linux-2.6.20.1/mm/oom_kill.c 2007-03-15 12:44:50.000000000 +0530
> @@ -320,7 +320,7 @@
> * Don't kill the process if any threads are set to OOM_DISABLE
> */
> do_each_thread(g, q) {
> - if (q->mm == mm && p->oomkilladj == OOM_DISABLE)
> + if (q->mm == mm && q->oomkilladj == OOM_DISABLE)
> return 1;
> } while_each_thread(g, q);
>
>
> Regards,
> --
> Ankita Garg (ankita@in.ibm.com)
> Linux Technology Center
> IBM India Systems & Technology Labs,
> Bangalore, India
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable
2007-03-15 13:49 [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable Ankita Garg
2007-03-15 13:52 ` Nick Piggin
@ 2007-03-15 22:22 ` William Lee Irwin III
1 sibling, 0 replies; 3+ messages in thread
From: William Lee Irwin III @ 2007-03-15 22:22 UTC (permalink / raw)
To: Ankita Garg; +Cc: Linux Memory Management, LKML, Nick Piggin, Andrew Morton
On Thu, Mar 15, 2007 at 07:19:21PM +0530, Ankita Garg wrote:
> Looking at oom_kill.c, found that the intention to not kill the selected
> process if any of its children/siblings has OOM_DISABLE set, is not being met.
> Signed-off-by: Ankita Garg <ankita@in.ibm.com>
> Index: ankita/linux-2.6.20.1/mm/oom_kill.c
> ===================================================================
> --- ankita.orig/linux-2.6.20.1/mm/oom_kill.c 2007-02-20 12:04:32.000000000 +0530
> +++ ankita/linux-2.6.20.1/mm/oom_kill.c 2007-03-15 12:44:50.000000000 +0530
> @@ -320,7 +320,7 @@
> * Don't kill the process if any threads are set to OOM_DISABLE
> */
> do_each_thread(g, q) {
> - if (q->mm == mm && p->oomkilladj == OOM_DISABLE)
> + if (q->mm == mm && q->oomkilladj == OOM_DISABLE)
> return 1;
> } while_each_thread(g, q);
Acked-by: William Irwin <wli@holomorphy.com>
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-15 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-15 13:49 [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable Ankita Garg
2007-03-15 13:52 ` Nick Piggin
2007-03-15 22:22 ` William Lee Irwin III
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox