Re: [patch 2/2] splice: dont readpage

[Nick Piggin <npiggin@suse.de>]

On Thu, Mar 15, 2007 at 12:54:54PM +0100, Jens Axboe wrote:
> On Wed, Mar 14 2007, Nick Piggin wrote:
> > 
> > Splice does not need to readpage to bring the page uptodate before writing
> > to it, because prepare_write will take care of that for us.
> 
> Ah great, always good to get rid of some code.

Yeah, it should especially make block (but not page) sized and aligned
writes into uncached files work much better, AFAIKS (won't require the
synchronous read).

> > Splice is also wrong to SetPageUptodate before the page is actually uptodate.
> > This results in the old uninitialised memory leak. This gets fixed as a
> > matter of course when removing the readpage logic.
> 
> Leak, how? The page should still be locked all through to the copy.
> Anyway, doesn't matter since you've killed it anyway. I have applied
> this patch.

The read side doesn't need to lock the page if it is uptodate, and doesn't.

Nick

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>