From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 15 Mar 2007 12:54:54 +0100 From: Jens Axboe Subject: Re: [patch 2/2] splice: dont readpage Message-ID: <20070315115454.GN15400@kernel.dk> References: <20070314121440.GA926@wotan.suse.de> <20070314121543.GB926@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070314121543.GB926@wotan.suse.de> Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Andrew Morton , Linux Kernel Mailing List , Linux Memory Management List List-ID: On Wed, Mar 14 2007, Nick Piggin wrote: > > Splice does not need to readpage to bring the page uptodate before writing > to it, because prepare_write will take care of that for us. Ah great, always good to get rid of some code. > Splice is also wrong to SetPageUptodate before the page is actually uptodate. > This results in the old uninitialised memory leak. This gets fixed as a > matter of course when removing the readpage logic. Leak, how? The page should still be locked all through to the copy. Anyway, doesn't matter since you've killed it anyway. I have applied this patch. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org