From: Jens Axboe <jens.axboe@oracle.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [patch 2/2] splice: dont readpage
Date: Thu, 15 Mar 2007 12:54:54 +0100 [thread overview]
Message-ID: <20070315115454.GN15400@kernel.dk> (raw)
In-Reply-To: <20070314121543.GB926@wotan.suse.de>
On Wed, Mar 14 2007, Nick Piggin wrote:
>
> Splice does not need to readpage to bring the page uptodate before writing
> to it, because prepare_write will take care of that for us.
Ah great, always good to get rid of some code.
> Splice is also wrong to SetPageUptodate before the page is actually uptodate.
> This results in the old uninitialised memory leak. This gets fixed as a
> matter of course when removing the readpage logic.
Leak, how? The page should still be locked all through to the copy.
Anyway, doesn't matter since you've killed it anyway. I have applied
this patch.
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-03-15 11:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 12:14 [patch 1/2] splice: dont steal Nick Piggin
2007-03-14 12:15 ` [patch 2/2] splice: dont readpage Nick Piggin
2007-03-15 11:54 ` Jens Axboe [this message]
2007-03-15 12:27 ` Nick Piggin
2007-03-15 12:38 ` Jens Axboe
2007-03-15 11:52 ` [patch 1/2] splice: dont steal Jens Axboe
2007-03-15 12:22 ` Nick Piggin
2007-03-15 12:27 ` Jens Axboe
2007-03-15 12:45 ` Nick Piggin
2007-03-15 12:54 ` Jens Axboe
2007-03-15 13:13 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070315115454.GN15400@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox