From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 9 Mar 2007 00:23:49 +0100 From: Pavel Machek Subject: Re: [RFC][PATCH 0/3] swsusp: Do not use page flags (was: Re: Remove page flags for software suspend) Message-ID: <20070308232349.GD1977@elf.ucw.cz> References: <200703041450.02178.rjw@sisk.pl> <1173315625.3546.32.camel@johannes.berg> <200703082305.43513.rjw@sisk.pl> <20070308231512.GB1977@elf.ucw.cz> <1173396094.3831.42.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1173396094.3831.42.camel@johannes.berg> Sender: owner-linux-mm@kvack.org Return-Path: To: Johannes Berg Cc: "Rafael J. Wysocki" , Nick Piggin , Christoph Lameter , linux-mm@kvack.org, pm list , Peter Zijlstra List-ID: Hi! > > That's a no-no. ATOMIC alocations can fail, and no, WARN_ON is not > > enough. It is not a bug, they just fail. > > But like I said in my post, there's no way we can disable suspend to > disk when they do, right now anyway. Also, this can't be called any > later than a late initcall or such since it's __init, and thus there > shouldn't be memory pressure yet that would cause this to fail. > > In any case, I'd be much happier with having a "disable suspend" > variable so we could print a big warning and set that flag. Patch would probably be accepted ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org