From: Andrew Morton <akpm@linux-foundation.org>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] swap prefetch: avoid repeating entry
Date: Tue, 6 Mar 2007 23:26:20 -0800 [thread overview]
Message-ID: <20070306232620.1162457a.akpm@linux-foundation.org> (raw)
In-Reply-To: <200703071814.04531.kernel@kolivas.org>
On Wed, 7 Mar 2007 18:14:04 +1100 Con Kolivas <kernel@kolivas.org> wrote:
> I've been unable for 4 months to find someone to test this Andrew. I'm going
> to assume it fixes the problem on numa=64 (or something like that) so please
> apply it.
>
> ---
> Avoid entering trickle_swap() when first initialising kprefetchd to prevent
> endless loops.
>
> Signed-off-by: Con Kolivas <kernel@kolivas.org>
>
> ---
> mm/swap_prefetch.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> Index: linux-2.6.21-rc2-mm2/mm/swap_prefetch.c
> ===================================================================
> --- linux-2.6.21-rc2-mm2.orig/mm/swap_prefetch.c 2007-03-06 22:23:26.000000000 +1100
> +++ linux-2.6.21-rc2-mm2/mm/swap_prefetch.c 2007-03-07 18:11:50.000000000 +1100
> @@ -515,6 +515,10 @@ static int kprefetchd(void *__unused)
> /* Set ioprio to lowest if supported by i/o scheduler */
> sys_ioprio_set(IOPRIO_WHO_PROCESS, 0, IOPRIO_CLASS_IDLE);
>
> + /* kprefetchd has nothing to do until it is woken up the first time */
> + set_current_state(TASK_INTERRUPTIBLE);
> + schedule();
> +
> do {
> try_to_freeze();
>
hm, yes, strange.
You can do poor-man's NUMA by setting CONFIG_NUMA_EMU and booting with
`numa=fake=16' Requires x86_64 and perhaps the fake-numa fixes in -mm.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-03-07 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 7:14 Con Kolivas
2007-03-07 7:26 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070306232620.1162457a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kernel@kolivas.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox