From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 6 Mar 2007 01:33:04 +0100 From: Nick Piggin Subject: Re: [rfc][patch 1/2] mm: rework isolate_lru_page Message-ID: <20070306003304.GA23845@wotan.suse.de> References: <20070305161655.GC8128@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Linux Memory Management List , Andrew Morton List-ID: On Mon, Mar 05, 2007 at 09:47:16AM -0800, Christoph Lameter wrote: > On Mon, 5 Mar 2007, Nick Piggin wrote: > > > isolate_lru_page logically belongs to be in vmscan.c than migrate.c. > > Good idea. > > > + * Isolate one page from the LRU lists. Must be called with an elevated > > + * refcount on the page, which is how it differs from isolate_lru_pages > > + * (which is called without a stable reference). > > + * > > + * lru_lock must not be held, interrupts must be enabled. > > + * > > + * Returns: > > + * -EBUSY: page not on LRU list > > + * 0: page removed from LRU list and added to the specified list. > > The new version of isolate_lru_page no longer adds the page to a list. > Remove that portion. Ah, thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org