From: Nick Piggin <npiggin@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [rfc][patch 1/2] mm: rework isolate_lru_page
Date: Tue, 6 Mar 2007 01:33:04 +0100 [thread overview]
Message-ID: <20070306003304.GA23845@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0703050945290.6620@schroedinger.engr.sgi.com>
On Mon, Mar 05, 2007 at 09:47:16AM -0800, Christoph Lameter wrote:
> On Mon, 5 Mar 2007, Nick Piggin wrote:
>
> > isolate_lru_page logically belongs to be in vmscan.c than migrate.c.
>
> Good idea.
>
> > + * Isolate one page from the LRU lists. Must be called with an elevated
> > + * refcount on the page, which is how it differs from isolate_lru_pages
> > + * (which is called without a stable reference).
> > + *
> > + * lru_lock must not be held, interrupts must be enabled.
> > + *
> > + * Returns:
> > + * -EBUSY: page not on LRU list
> > + * 0: page removed from LRU list and added to the specified list.
>
> The new version of isolate_lru_page no longer adds the page to a list.
> Remove that portion.
Ah, thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-03-06 0:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 16:16 Nick Piggin
2007-03-05 17:47 ` Christoph Lameter
2007-03-06 0:33 ` Nick Piggin [this message]
2007-03-06 0:54 ` Andrew Morton
2007-03-06 4:07 ` Nick Piggin
2007-03-06 4:42 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070306003304.GA23845@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@engr.sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox