linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@osdl.org, hch@infradead.org, a.p.zijlstra@chello.nl,
	mbligh@mbligh.org, arjan@infradead.org, nickpiggin@yahoo.com.au,
	linux-mm@kvack.org, mpm@selenic.com, nigel@nigel.suspend2.net,
	riel@redhat.com
Subject: Re: [PATCH 7/7] Opportunistically move mlocked pages off the LRU
Date: Thu, 15 Feb 2007 13:39:36 +0900	[thread overview]
Message-ID: <20070215133936.47ca3640.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20070215012525.5343.71985.sendpatchset@schroedinger.engr.sgi.com>

On Wed, 14 Feb 2007 17:25:26 -0800 (PST)
Christoph Lameter <clameter@sgi.com> wrote:

> Opportunistically move mlocked pages off the LRU
> 
> Add a new function try_to_mlock() that attempts to
> move a page off the LRU and marks it mlocked.
> 
> This function can then be used in various code paths to move
> pages off the LRU immediately. Early discovery will make NR_MLOCK
> track the actual number of mlocked pages in the system more closely.
> 

How about adding this check ?

>  struct page *follow_page(struct vm_area_struct *vma, unsigned long address,
> @@ -979,6 +1008,8 @@
>  			set_page_dirty(page);
>  		mark_page_accessed(page);
>  	}
> +	if (vma->vm_flags & VM_LOCKED)
> +		try_to_set_mlocked(page);

if (page != ZERO_PAGE(addres) && vma->vm_flags & VM_LOCKED)
		try_to_set_mlocked(pages);


I'm sorry if I misunderstand how ZERO_PAGE works.

-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-02-15  4:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15  1:24 [PATCH 0/7] Move mlocked pages off the LRU and track them V1 Christoph Lameter
2007-02-15  1:24 ` [PATCH 1/7] Make try_to_unmap return a special exit code Christoph Lameter
2007-02-15  1:24 ` [PATCH 2/7] Add PageMlocked() page state bit and lru infrastructure Christoph Lameter
2007-02-15  2:09   ` Matt Mackall
2007-02-15  2:30     ` Christoph Lameter
2007-02-15 14:51       ` Matt Mackall
2007-02-15 15:24         ` Christoph Lameter
2007-02-15 15:47           ` Martin J. Bligh
2007-02-15 16:05             ` Christoph Lameter
2007-02-15  1:25 ` [PATCH 3/7] Add NR_MLOCK ZVC Christoph Lameter
2007-02-15  1:25 ` [PATCH 4/7] Logic to move mlocked pages Christoph Lameter
2007-02-15  5:33   ` Andrew Morton
2007-02-15 15:19     ` Christoph Lameter
2007-02-15  5:39   ` Andrew Morton
2007-02-15 15:21     ` Christoph Lameter
2007-02-15  1:25 ` [PATCH 5/7] Consolidate new anonymous page code paths Christoph Lameter
2007-02-15  1:25 ` [PATCH 6/7] Avoid putting new mlocked anonymous pages on LRU Christoph Lameter
2007-02-15  1:25 ` [PATCH 7/7] Opportunistically move mlocked pages off the LRU Christoph Lameter
2007-02-15  4:39   ` KAMEZAWA Hiroyuki [this message]
2007-02-15 15:15     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070215133936.47ca3640.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=clameter@sgi.com \
    --cc=hch@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=mbligh@mbligh.org \
    --cc=mpm@selenic.com \
    --cc=nickpiggin@yahoo.com.au \
    --cc=nigel@nigel.suspend2.net \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox