From: Adam Litke <agl@us.ibm.com>
To: linux-mm@kvack.org
Cc: agl@us.ibm.com, wli@holomorphy.com, kenchen@google.com,
hugh@veritas.com, david@gibson.dropbear.id.au
Subject: [PATCH 0/6] hugetlb: Remove is_file_hugepages() macro
Date: Wed, 31 Jan 2007 12:16:24 -0800 [thread overview]
Message-ID: <20070131201624.13810.45848.stgit@localhost.localdomain> (raw)
The kernel code is currently peppered with special casing for hugetlbfs
mappings. In many places we check a struct file's f_op member to see if it
points to the hugetlbfs file_operations in which case we'll employ some sort of
workaround. The need to check file_operations in this manner suggests that we
are either missing f_op operations, or have deficient abstraction elsewhere.
I am motivated to clean this up for two reasons: 1) The community has asked
for huge pages to be kept "on the side" of the main VM. I believe these
patches advance that goal. 2) Proper abstraction of hugetlbfs allows the
underlying implementation to be changed without disturbing the main VM.
Removing the is_file_hugepages() macro involved finding all the call sites,
determining the actual incompatibility that huge page mappings introduce, and
applying a relatively trivial fix for the problem. The following patches
perform this surgery.
When converting these, I have tried to use as general of a solution as
possible. Review of some of the design decisions would be appreciated --
specifically the use of backing_dev_info for the note about special accounting,
and hugetlbfs sharing the inode_info struct with shmem.
Thanks to Andy Whitcroft and others for review of the preliminary patches.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2007-01-31 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 20:16 Adam Litke [this message]
2007-01-31 20:16 ` [PATCH 1/6] Define the shmem_inode_info flags directly Adam Litke
2007-01-31 20:16 ` [PATCH 2/6] hugetlb: share shmem_inode_info Adam Litke
2007-01-31 20:16 ` [PATCH 3/6] Use inode_info to annotate hugetlbfs shm segments Adam Litke
2007-01-31 20:17 ` [PATCH 4/6] hugetlb: hugetlbfs handles overcommit accounting privately Adam Litke
2007-01-31 20:17 ` [PATCH 5/6] Abstract is_hugepage_only_range Adam Litke
2007-01-31 20:17 ` [PATCH 6/6] hugetlb: Remove is_file_hugepages() Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070131201624.13810.45848.stgit@localhost.localdomain \
--to=agl@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=hugh@veritas.com \
--cc=kenchen@google.com \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox