Re: [2.6 patch] the scheduled find_trylock_page() removal

Re: [2.6 patch] the scheduled find_trylock_page() removal

[Nick Piggin]

Adrian Bunk wrote:
> This patch contains the scheduled find_trylock_page() removal.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

I guess I don't have a problem with this going into -mm and making its way
upstream sometime after the next release.

I would normally say it is OK to stay for another year because it is so
unintrusive, but I don't like the fact it doesn't give one an explicit ref
on the page -- it could be misused slightly more easily than find_lock_page
or find_get_page.

Anyone object? Otherwise:

Acked-by: Nick Piggin <npiggin@suse.de>

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [2.6 patch] the scheduled find_trylock_page() removal

[Christoph Hellwig]

On Thu, Jan 04, 2007 at 03:53:07PM +1100, Nick Piggin wrote:
> Adrian Bunk wrote:
> >This patch contains the scheduled find_trylock_page() removal.
> >
> >Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> I guess I don't have a problem with this going into -mm and making its way
> upstream sometime after the next release.
> 
> I would normally say it is OK to stay for another year because it is so
> unintrusive, but I don't like the fact it doesn't give one an explicit ref
> on the page -- it could be misused slightly more easily than find_lock_page
> or find_get_page.
> 
> Anyone object? Otherwise:

Just kill it.  There's absolutely no point in keeping dead code around.
It's bad enough we keep such things around for half a year.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>