From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 28 Dec 2006 09:29:34 +0900 From: Paul Mundt Subject: Re: [PATCH] Sanely size hash tables when using large base pages. Message-ID: <20061228002934.GA18755@linux-sh.org> References: <20061226061652.GA598@linux-sh.org> <20061226074257.GA5853@mail.ustc.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061226074257.GA5853@mail.ustc.edu.cn> Sender: owner-linux-mm@kvack.org Return-Path: To: linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Tue, Dec 26, 2006 at 03:42:57PM +0800, Fengguang Wu wrote: > On Tue, Dec 26, 2006 at 03:16:52PM +0900, Paul Mundt wrote: > > pidhash_shift = max(4, fls(megabytes * 4)); > > pidhash_shift = min(12, pidhash_shift); > > pidhash_size = 1 << pidhash_shift; > > > > + size = pidhash_size * sizeof(struct hlist_head); > > + if (unlikely(size < PAGE_SIZE)) { > > + size = PAGE_SIZE; > > + pidhash_size = size / sizeof(struct hlist_head); > > + pidhash_shift = 0; > > But pidhash_shift is not the order of page ;-) > Ah, you're right. I'll drop the pidhash changes and resubmit. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org