From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: clameter@sgi.com, linux-mm@kvack.org, clameter@engr.sgi.com,
apw@shadowen.org
Subject: Re: [RFC][PATCH] vmemmap on sparsemem v2 [1/5] generic vmemmap on sparsemem
Date: Thu, 7 Dec 2006 19:50:23 +0900 [thread overview]
Message-ID: <20061207195023.11cb3b52.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20061207101156.GB9059@osiris.ibm.com>
On Thu, 7 Dec 2006 11:11:56 +0100
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> > > vmap_end is only page aligned if sizeof(struct page) and PAGES_PER_SECTION
> > > play nicely together. Which may not be the case on 64 bit platforms where
> > > sizeof(struct page) is not a power of two.
> > >
> > Now, (for example ia64) sizeof(struct page)=56 and PAGES_PER_SECTION=65536,
> > Then, sizeof(struct page) * PAGES_PER_SECTION is page-aligned.(16kbytes pages.)
>
> sizeof(struct page) depends also on at least two CONFIG options. I don't
> think it's a good idea to assume that everything is page aligned, just
> because it works right now and only with certain kernel configurations...
> At least the kernel build should fail if your assumptions are not true
> anymore.
>
I'll add #error and check it. thanks.
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-12-07 10:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 12:45 [RFC][PATCH] vmemmap on sparsemem v2 KAMEZAWA Hiroyuki
2006-12-05 12:49 ` [RFC][PATCH] vmemmap on sparsemem v2 [1/5] generic vmemmap on sparsemem KAMEZAWA Hiroyuki
2006-12-06 18:13 ` Heiko Carstens
2006-12-06 18:17 ` Christoph Lameter
2006-12-07 0:20 ` KAMEZAWA Hiroyuki
2006-12-07 0:20 ` Christoph Lameter
2006-12-07 10:11 ` Heiko Carstens
2006-12-07 10:50 ` KAMEZAWA Hiroyuki [this message]
2006-12-07 10:06 ` Heiko Carstens
2006-12-07 10:17 ` KAMEZAWA Hiroyuki
2006-12-08 3:06 ` KAMEZAWA Hiroyuki
2006-12-05 12:53 ` [RFC][PATCH] vmemmap on sparsemem v2 [2/5] memory hotplug support KAMEZAWA Hiroyuki
2006-12-05 12:59 ` [RFC][PATCH] vmemmap on sparsemem v2 [3/5] ia64 vmemamp on sparsemem KAMEZAWA Hiroyuki
2006-12-08 1:09 ` KAMEZAWA Hiroyuki
2006-12-05 13:09 ` [RFC][PATCH] vmemmap on sparsemem v2 [4/5] optimized pfn_valid KAMEZAWA Hiroyuki
2006-12-05 13:10 ` [RFC][PATCH] vmemmap on sparsemem v2 [5/5] optimzied pfn_valid support for ia64 KAMEZAWA Hiroyuki
2006-12-10 13:37 ` [RFC][PATCH] vmemmap on sparsemem v2 Andy Whitcroft
2006-12-10 15:19 ` Heiko Carstens
2006-12-11 1:09 ` KAMEZAWA Hiroyuki
2006-12-11 17:23 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207195023.11cb3b52.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=apw@shadowen.org \
--cc=clameter@engr.sgi.com \
--cc=clameter@sgi.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox