linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-mm@kvack.org
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 10/16] mm: remove find_tylock_page
Date: Thu, 07 Dec 2006 17:18:10 +0100	[thread overview]
Message-ID: <20061207162736.184390000@chello.nl> (raw)
In-Reply-To: <20061207161800.426936000@chello.nl>

[-- Attachment #1: kill-find_trylock_page.patch --]
[-- Type: text/plain, Size: 2272 bytes --]

its the last read_lock user of tree_lock, and since its unused remove
it rather than convert it.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 include/linux/pagemap.h |    2 --
 mm/filemap.c            |   20 --------------------
 2 files changed, 22 deletions(-)

Index: linux-2.6-rt/mm/filemap.c
===================================================================
--- linux-2.6-rt.orig/mm/filemap.c	2006-11-30 17:24:49.000000000 +0100
+++ linux-2.6-rt/mm/filemap.c	2006-11-30 17:25:29.000000000 +0100
@@ -613,26 +613,6 @@ repeat:
 EXPORT_SYMBOL(find_get_page);
 
 /**
- * find_trylock_page - find and lock a page
- * @mapping: the address_space to search
- * @offset: the page index
- *
- * Same as find_get_page(), but trylock it instead of incrementing the count.
- */
-struct page *find_trylock_page(struct address_space *mapping, unsigned long offset)
-{
-	struct page *page;
-
-	read_lock_irq(&mapping->tree_lock);
-	page = radix_tree_lookup(&mapping->page_tree, offset);
-	if (page && TestSetPageLocked(page))
-		page = NULL;
-	read_unlock_irq(&mapping->tree_lock);
-	return page;
-}
-EXPORT_SYMBOL(find_trylock_page);
-
-/**
  * find_lock_page - locate, pin and lock a pagecache page
  * @mapping: the address_space to search
  * @offset: the page index
Index: linux-2.6-rt/include/linux/pagemap.h
===================================================================
--- linux-2.6-rt.orig/include/linux/pagemap.h	2006-11-30 17:24:59.000000000 +0100
+++ linux-2.6-rt/include/linux/pagemap.h	2006-11-30 17:27:38.000000000 +0100
@@ -251,8 +251,6 @@ extern struct page * find_get_page(struc
 				unsigned long index);
 extern struct page * find_lock_page(struct address_space *mapping,
 				unsigned long index);
-extern __deprecated_for_modules struct page * find_trylock_page(
-			struct address_space *mapping, unsigned long index);
 extern struct page * find_or_create_page(struct address_space *mapping,
 				unsigned long index, gfp_t gfp_mask);
 unsigned find_get_pages(struct address_space *mapping, pgoff_t start,

--

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2006-12-07 16:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07 16:18 [PATCH 00/16] concurrent pagecache (against 2.6.19-rt) Peter Zijlstra
2006-12-07 16:18 ` [PATCH 01/16] radix-tree: RCU lockless readside Nick Piggin
2006-12-07 16:18 ` [PATCH 02/16] radix-tree: use indirect bit Nick Piggin
2006-12-07 16:18 ` [PATCH 03/16] radix-tree: gang_lookup_slot Nick Piggin
2006-12-07 16:18 ` [PATCH 04/16] radix-tree: gang_lookup_tag_slot Peter Zijlstra
2006-12-07 16:18 ` [PATCH 05/16] mm: speculative get page Nick Piggin
2006-12-07 16:18 ` [PATCH 06/16] mm: lockless pagecache lookups Nick Piggin
2006-12-07 16:18 ` [PATCH 07/16] mm: fix speculative page get preemption bug Peter Zijlstra
2006-12-07 16:18 ` [PATCH 08/16] mm: speculative page get for PREEMPT_RT Peter Zijlstra
2006-12-07 16:18 ` [PATCH 09/16] mm: speculative find_get_pages_tag Peter Zijlstra
2006-12-07 16:18 ` Peter Zijlstra [this message]
2006-12-07 16:18 ` [PATCH 11/16] mm: change tree_lock into a spinlock Peter Zijlstra
2006-12-07 16:18 ` [PATCH 12/16] radix-tree: concurrent write side support Peter Zijlstra
2006-12-07 16:18 ` [PATCH 13/16] atomic_ulong_t Peter Zijlstra
2006-12-07 16:18 ` [PATCH 14/16] mm/fs: abstract address_space::nrpages Peter Zijlstra
2006-12-07 16:18 ` [PATCH 15/16] mm: lock_page_ref Peter Zijlstra
2006-12-07 16:18 ` [PATCH 16/16] mm: concurrent pagecache write side Peter Zijlstra
2006-12-11 19:03 ` [PATCH 00/16] concurrent pagecache (against 2.6.19-rt) Christoph Lameter
2006-12-11 19:24   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061207162736.184390000@chello.nl \
    --to=a.p.zijlstra@chello.nl \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox