Re: [RFC 1/7] Remove declaration of sighand_cachep from slab.h

[Andrew Morton <akpm@osdl.org>]

On Tue, 21 Nov 2006 11:56:33 -0800 (PST)
Christoph Lameter <clameter@sgi.com> wrote:

> On Tue, 21 Nov 2006, Andrew Morton wrote:
> 
> > spose so, although I wouldn't bother about the typedef->#define change.  
> > We just keep on plugging away at it until one day we can just remove the typedef.
> 
> You do have script that can replace a string throughout the kernel 
> right?

Nope.

> 
> A patch is following that does the core things in mm and 
> include/linux/slab.h. Would you accept that patch and then do
> 
> s/kmem_cache_t/struct kmem_cache/g
> 
> over all the kernel sources?

This is one of those low-priority background activities.  Not worth
a lot of fuss.

I'd suggest that you proceeed with the original cleanups you were
proposing, except use `struct kmem_cache' in header files rather than
kmem_cache_t in .c files.

Then, as a separate and later exercise someone (maybe you) can raise
patches to do the kmem_cache_t->kmem_cache conversion.  They should go
through maintainers hence they should be appropriately split and they will
take months to all get to mainline.  Once this is all completed we can remove the
typedef.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>