From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 21 Nov 2006 00:07:43 -0800 From: Andrew Morton Subject: Re: [RFC 1/7] Remove declaration of sighand_cachep from slab.h Message-Id: <20061121000743.bb9ea2d0.akpm@osdl.org> In-Reply-To: References: <20061118054342.8884.12804.sendpatchset@schroedinger.engr.sgi.com> <20061118054347.8884.36259.sendpatchset@schroedinger.engr.sgi.com> <20061118172739.30538d16.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Stephen Rothwell , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pekka Enberg , Manfred Spraul List-ID: On Mon, 20 Nov 2006 08:20:13 -0800 (PST) Christoph Lameter wrote: > On Sat, 18 Nov 2006, Stephen Rothwell wrote: > > > Is there no suitable header file to put this in? > > There is only a single file that uses sighand_cachep apart from where it > was defined. If we would add it to signal.h then we would also have to > add an include for slab.h just for this statement. That's one of the reasons why typedefs are bad. Use `struct kmem_cache' instead of `kmem_cache_t' and lo, you can forward-declare it in the header file without having to include slab.h. Patches which rid us of kmem_cache_t are always welcome.. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org