From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Pekka Enberg <penberg@cs.helsinki.fi>,
Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [RFC 1/7] Remove declaration of sighand_cachep from slab.h
Date: Tue, 21 Nov 2006 00:07:43 -0800 [thread overview]
Message-ID: <20061121000743.bb9ea2d0.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0611200817020.16173@schroedinger.engr.sgi.com>
On Mon, 20 Nov 2006 08:20:13 -0800 (PST)
Christoph Lameter <clameter@sgi.com> wrote:
> On Sat, 18 Nov 2006, Stephen Rothwell wrote:
>
> > Is there no suitable header file to put this in?
>
> There is only a single file that uses sighand_cachep apart from where it
> was defined. If we would add it to signal.h then we would also have to
> add an include for slab.h just for this statement.
That's one of the reasons why typedefs are bad.
Use `struct kmem_cache' instead of `kmem_cache_t' and lo, you can
forward-declare it in the header file without having to include slab.h.
Patches which rid us of kmem_cache_t are always welcome..
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-11-21 8:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-18 5:43 [RFC 0/7] Remove slab cache declarations in slab.h Christoph Lameter
2006-11-18 5:43 ` [RFC 1/7] Remove declaration of sighand_cachep from slab.h Christoph Lameter
2006-11-18 6:27 ` Stephen Rothwell
2006-11-20 16:20 ` Christoph Lameter
2006-11-21 8:07 ` Andrew Morton [this message]
2006-11-21 19:36 ` Christoph Lameter
2006-11-21 19:49 ` Andrew Morton
2006-11-21 19:56 ` Christoph Lameter
2006-11-21 20:07 ` Andrew Morton
2006-11-18 5:43 ` [RFC 2/7] Remove bio_cachep " Christoph Lameter
2006-11-18 5:43 ` [RFC 3/7] Move vm_area_cachep to mm.h Christoph Lameter
2006-11-18 5:44 ` [RFC 4/7] Move files_cachep to file.h Christoph Lameter
2006-11-21 8:09 ` Andrew Morton
2006-11-18 5:44 ` [RFC 5/7] Use external declaration for filep_cachep Christoph Lameter
2006-11-18 6:31 ` Stephen Rothwell
2006-11-20 16:20 ` Christoph Lameter
2006-11-18 5:44 ` [RFC 6/7] Use an external declaration in exit.c for fs_cachep Christoph Lameter
2006-11-18 6:32 ` Stephen Rothwell
2006-11-20 16:21 ` Christoph Lameter
2006-11-18 5:44 ` [RFC 7/7] Move names_cachep to fs.h Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061121000743.bb9ea2d0.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=penberg@cs.helsinki.fi \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox