From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Pekka Enberg <penberg@cs.helsinki.fi>,
Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [RFC 5/7] Use external declaration for filep_cachep
Date: Sat, 18 Nov 2006 17:31:00 +1100 [thread overview]
Message-ID: <20061118173100.3a8b7293.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20061118054408.8884.53656.sendpatchset@schroedinger.engr.sgi.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
On Fri, 17 Nov 2006 21:44:08 -0800 (PST) Christoph Lameter <clameter@sgi.com> wrote:
>
> Use external declaration for filep_cachep.
>
> filp_cachep is used in fs/file_table.c. Its defined in fs/dcache.c.
> The easiest solution here is to add an external declaration to
> fs/file_table.c.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>
> --- linux-2.6.19-rc5-mm2.orig/fs/file_table.c 2006-11-15 16:47:59.622264626 -0600
> +++ linux-2.6.19-rc5-mm2/fs/file_table.c 2006-11-17 23:04:05.885291107 -0600
> @@ -35,6 +35,8 @@ __cacheline_aligned_in_smp DEFINE_SPINLO
>
> static struct percpu_counter nr_files __cacheline_aligned_in_smp;
>
> +extern kmem_cache_t *filp_cachep;
Is there no suitable header file to put this in?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-11-18 6:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-18 5:43 [RFC 0/7] Remove slab cache declarations in slab.h Christoph Lameter
2006-11-18 5:43 ` [RFC 1/7] Remove declaration of sighand_cachep from slab.h Christoph Lameter
2006-11-18 6:27 ` Stephen Rothwell
2006-11-20 16:20 ` Christoph Lameter
2006-11-21 8:07 ` Andrew Morton
2006-11-21 19:36 ` Christoph Lameter
2006-11-21 19:49 ` Andrew Morton
2006-11-21 19:56 ` Christoph Lameter
2006-11-21 20:07 ` Andrew Morton
2006-11-18 5:43 ` [RFC 2/7] Remove bio_cachep " Christoph Lameter
2006-11-18 5:43 ` [RFC 3/7] Move vm_area_cachep to mm.h Christoph Lameter
2006-11-18 5:44 ` [RFC 4/7] Move files_cachep to file.h Christoph Lameter
2006-11-21 8:09 ` Andrew Morton
2006-11-18 5:44 ` [RFC 5/7] Use external declaration for filep_cachep Christoph Lameter
2006-11-18 6:31 ` Stephen Rothwell [this message]
2006-11-20 16:20 ` Christoph Lameter
2006-11-18 5:44 ` [RFC 6/7] Use an external declaration in exit.c for fs_cachep Christoph Lameter
2006-11-18 6:32 ` Stephen Rothwell
2006-11-20 16:21 ` Christoph Lameter
2006-11-18 5:44 ` [RFC 7/7] Move names_cachep to fs.h Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061118173100.3a8b7293.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox