From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@lst.de>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] add numa node information to struct device
Date: Wed, 15 Nov 2006 15:15:35 -0800 [thread overview]
Message-ID: <20061115151535.ef1beadb.akpm@osdl.org> (raw)
In-Reply-To: <20061115173701.GB18244@lst.de>
On Wed, 15 Nov 2006 18:37:01 +0100
Christoph Hellwig <hch@lst.de> wrote:
> +#ifdef CONFIG_NUMA
> +#define dev_to_node(dev) ((dev)->numa_node)
> +#define set_dev_node(dev, node) ((dev)->numa_node = node)
> +#else
> +#define dev_to_node(dev) (-1)
> +#define set_dev_node(dev, node) do { } while (0)
> +#endif
minor point: using inlines here would give typechecking, prevent possible
unused-var warnings, etc.
Maybe there was a reason for not doing that.
<does it>
No doubt I'll find out ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-11-15 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 17:37 Christoph Hellwig
2006-11-15 23:15 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061115151535.ef1beadb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox