From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [RFC][PATCH 5/8] RSS controller task migration support Message-Id: <20061115115937.B0A851B6A2@openx4.frec.bull.fr> Date: Wed, 15 Nov 2006 12:59:37 +0100 (CET) From: Patrick.Le-Dot@bull.net (Patrick.Le-Dot) Sender: owner-linux-mm@kvack.org Return-Path: To: balbir@in.ibm.com Cc: ckrm-tech@lists.sourceforge.net, dev@openvz.org, haveblue@us.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rohitseth@google.com List-ID: Hi Balbir, The get_task_mm()/mmput(mm) usage is not correct. With CONFIG_DEBUG_SPINLOCK_SLEEP=y : BUG: sleeping function called from invalid context at kernel/fork.c:390 in_atomic():1, irqs_disabled():0 [] __might_sleep+0x97/0x9c [] mmput+0x15/0x8b [] install_arg_page+0x72/0xa9 [] setup_arg_pages+0x184/0x1a5 ... BUG: sleeping function called from invalid context at kernel/fork.c:390 in_atomic():1, irqs_disabled():0 [] __might_sleep+0x97/0x9c [] mmput+0x15/0x8b [] do_no_page+0x255/0x2bd [] __handle_mm_fault+0xed/0x1ef [] do_page_fault+0x247/0x506 [] do_page_fault+0x0/0x506 [] error_code+0x39/0x40 current->mm seems to be enough here. In patch4, memctlr_dec_rss(page, mm) should be memctlr_dec_rss(page) to compile correctly. and in patch0 : > 4. Disable cpuset's (to simply assignment of tasks to resource groups) > cd /container > echo 0 > cpuset_enabled should be : echo 0 > cpuacct_enabled Note : cpuacct_enabled is 0 by default. Now the big question : to implement guarantee, the LRU needs to know if a page can be removed from memory or not. Any ideas to do that without any change in the struct page ? Patrick +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+ Patrick Le Dot mailto: P@trick.Le-Dot@bull.net Centre UNIX de BULL SAS Phone : +33 4 76 29 73 20 1, Rue de Provence BP 208 Fax : +33 4 76 29 76 00 38130 ECHIROLLES Cedex FRANCE Bull, Architect of an Open World TM www.bull.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org