From: Balbir Singh <balbir@in.ibm.com>
To: Linux MM <linux-mm@kvack.org>
Cc: dev@openvz.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ckrm-tech@lists.sourceforge.net, haveblue@us.ibm.com,
rohitseth@google.com, Balbir Singh <balbir@in.ibm.com>
Subject: [RFC][PATCH 3/8] RSS controller add callbacks
Date: Fri, 10 Nov 2006 01:05:51 +0530 [thread overview]
Message-ID: <20061109193551.21437.44408.sendpatchset@balbir.in.ibm.com> (raw)
In-Reply-To: <20061109193523.21437.86224.sendpatchset@balbir.in.ibm.com>
Add callbacks to allocate and free instances of the controller as the
hierarchy of resource groups is modified.
Signed-off-by: Balbir Singh <balbir@in.ibm.com>
---
kernel/res_group/memctlr.c | 58 ++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 55 insertions(+), 3 deletions(-)
diff -puN kernel/res_group/memctlr.c~container-memctlr-callbacks kernel/res_group/memctlr.c
--- linux-2.6.19-rc2/kernel/res_group/memctlr.c~container-memctlr-callbacks 2006-11-09 21:42:35.000000000 +0530
+++ linux-2.6.19-rc2-balbir/kernel/res_group/memctlr.c 2006-11-09 21:42:35.000000000 +0530
@@ -34,6 +34,8 @@
static const char res_ctlr_name[] = "memctlr";
static struct resource_group *root_rgroup;
+static const char version[] = "0.01";
+static struct memctlr *memctlr_root;
struct mem_counter {
atomic_long_t rss;
@@ -64,14 +66,64 @@ static struct memctlr *get_memctlr(struc
&memctlr_rg));
}
+static void memctlr_init_new(struct memctlr *res)
+{
+ res->shares.min_shares = SHARE_DONT_CARE;
+ res->shares.max_shares = SHARE_DONT_CARE;
+ res->shares.child_shares_divisor = SHARE_DEFAULT_DIVISOR;
+ res->shares.unused_min_shares = SHARE_DEFAULT_DIVISOR;
+}
+
+static struct res_shares *memctlr_alloc_instance(struct resource_group *rgroup)
+{
+ struct memctlr *res;
+
+ res = kzalloc(sizeof(struct memctlr), GFP_KERNEL);
+ if (!res)
+ return NULL;
+ res->rgroup = rgroup;
+ memctlr_init_new(res);
+ if (is_res_group_root(rgroup)) {
+ root_rgroup = rgroup;
+ memctlr_root = res;
+ printk("Memory Controller version %s\n", version);
+ }
+ return &res->shares;
+}
+
+static void memctlr_free_instance(struct res_shares *shares)
+{
+ struct memctlr *res, *parres;
+
+ res = get_memctlr_from_shares(shares);
+ BUG_ON(!res);
+ /*
+ * Containers do not allow removal of groups that have tasks
+ * associated with them. To free a container, it must be empty.
+ * Handle transfer of charges in the move_task notification
+ */
+ kfree(res);
+}
+
+static ssize_t memctlr_show_stats(struct res_shares *shares, char *buf,
+ size_t len)
+{
+ int i = 0;
+
+ i += snprintf(buf, len, "Accounting will be added soon\n");
+ buf += i;
+ len -= i;
+ return i;
+}
+
struct res_controller memctlr_rg = {
.name = res_ctlr_name,
.ctlr_id = NO_RES_ID,
- .alloc_shares_struct = NULL,
- .free_shares_struct = NULL,
+ .alloc_shares_struct = memctlr_alloc_instance,
+ .free_shares_struct = memctlr_free_instance,
.move_task = NULL,
.shares_changed = NULL,
- .show_stats = NULL,
+ .show_stats = memctlr_show_stats,
};
int __init memctlr_init(void)
_
--
Balbir Singh,
Linux Technology Center,
IBM Software Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-11-09 19:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 19:35 [RFC][PATCH 0/8] RSS controller for containers Balbir Singh
2006-11-09 19:35 ` [RFC][PATCH 1/8] Fix resource groups parsing, while assigning shares Balbir Singh
2006-11-09 19:35 ` [RFC][PATCH 2/8] RSS controller setup Balbir Singh
2006-11-09 19:35 ` Balbir Singh [this message]
2006-11-09 19:36 ` [RFC][PATCH 4/8] RSS controller accounting Balbir Singh
2006-11-10 9:06 ` Pavel Emelianov
2006-11-10 9:29 ` Balbir Singh
2006-11-09 19:36 ` [RFC][PATCH 5/8] RSS controller task migration support Balbir Singh
2006-11-09 19:36 ` [RFC][PATCH 6/8] RSS controller shares allocation Balbir Singh
2006-11-10 9:11 ` Pavel Emelianov
2006-11-10 10:27 ` [ckrm-tech] " Balbir Singh
2006-11-10 10:32 ` Pavel Emelianov
2006-11-10 12:55 ` Balbir Singh
2006-11-09 19:36 ` [RFC][PATCH 7/8] RSS controller fix resource groups parsing Balbir Singh
2006-11-10 9:13 ` Pavel Emelianov
2006-11-10 9:32 ` Balbir Singh
2006-11-09 19:36 ` [RFC][PATCH 8/8] RSS controller support reclamation Balbir Singh
2006-11-09 19:45 ` Arjan van de Ven
2006-11-10 1:56 ` [ckrm-tech] " Balbir Singh
2006-11-10 8:54 ` Pavel Emelianov
2006-11-10 9:16 ` Balbir Singh
2006-11-10 9:29 ` Pavel Emelianov
2006-11-10 12:42 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109193551.21437.44408.sendpatchset@balbir.in.ibm.com \
--to=balbir@in.ibm.com \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=dev@openvz.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rohitseth@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox