From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 8 Nov 2006 11:57:32 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH] Fix sys_move_pages when a NULL node list is passed. Message-Id: <20061108115732.fcd17f67.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20061108134744.ffc504ea.sfr@canb.auug.org.au> References: <20061103144243.4601ba76.sfr@canb.auug.org.au> <20061108105648.4a149cca.kamezawa.hiroyu@jp.fujitsu.com> <20061108111341.748d034a.kamezawa.hiroyu@jp.fujitsu.com> <20061108134744.ffc504ea.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Stephen Rothwell Cc: clameter@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org, akpm@osdl.org List-ID: On Wed, 8 Nov 2006 13:47:44 +1100 Stephen Rothwell wrote: > On Wed, 8 Nov 2006 11:13:41 +0900 KAMEZAWA Hiroyuki wrote: > > > > Ah.. I'm mentioning to this. > > == > > + pm[i].node = 0; /* anything to not match MAX_NUMNODES */ > > == > > Sorry for my bad cut & paste. > > > > It seems that this 0 will be passed to alloc_pages_node(). > > alloc_pages_node() doesn't check whether a node is online or not before using > > NODE_DATA(). > > Actually, it won't. If you do that assignment, then the nodes parameter > was NULL and you will only call do_pages_stat() and so never call > alloc_pages_node(). > Ah..Okay, I'm sorry for noise. -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org