From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 8 Nov 2006 11:13:41 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH] Fix sys_move_pages when a NULL node list is passed. Message-Id: <20061108111341.748d034a.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <20061103144243.4601ba76.sfr@canb.auug.org.au> <20061108105648.4a149cca.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org, akpm@osdl.org List-ID: On Tue, 7 Nov 2006 18:01:11 -0800 (PST) Christoph Lameter wrote: > On Wed, 8 Nov 2006, KAMEZAWA Hiroyuki wrote: > > > > pm[nr_pages].node = MAX_NUMNODES; > > > > I think node0 is always online...but this should be > > > > pm[i].node = first_online_node; // /* any online node */ > > No it is a marker. The use of any node that is online could lead to a > false determination of the endpoint of the list. > Ah.. I'm mentioning to this. == + pm[i].node = 0; /* anything to not match MAX_NUMNODES */ == Sorry for my bad cut & paste. It seems that this 0 will be passed to alloc_pages_node(). alloc_pages_node() doesn't check whether a node is online or not before using NODE_DATA(). -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org