From: David Miller <davem@davemloft.net>
From: Christoph Hellwig <hch@lst.de>
To: hch@lst.de
Cc: davej@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] add dev_to_node()
Date: Sun, 05 Nov 2006 00:22:37 -0800 (PST) [thread overview]
Date: Sun, 5 Nov 2006 00:53:23 +0100 [thread overview]
Message-ID: <20061105.002237.18309940.davem@davemloft.net> (raw)
In-Reply-To: <20061104235323.GA1353@lst.de>
> On Sat, Nov 04, 2006 at 06:06:48PM -0500, Dave Jones wrote:
> > On Sat, Nov 04, 2006 at 11:56:29PM +0100, Christoph Hellwig wrote:
> >
> > This will break the compile for !NUMA if someone ends up doing a bisect
> > and lands here as a bisect point.
> >
> > You introduce this nice wrapper..
>
> The dev_to_node wrapper is not enough as we can't assign to (-1) for
> the non-NUMA case. So I added a second macro, set_dev_node for that.
>
> The patch below compiles and works on numa and non-NUMA platforms.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-11-05 8:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 14:15 Christoph Hellwig
2006-10-30 22:33 ` David Miller, Christoph Hellwig
2006-11-01 0:10 ` Christoph Lameter
2006-11-01 0:53 ` David Miller, Christoph Lameter
2006-11-01 1:58 ` Christoph Lameter
2006-11-04 22:56 ` Christoph Hellwig
2006-11-04 23:06 ` Dave Jones
2006-11-04 23:09 ` Christoph Hellwig
2006-11-04 23:53 ` Christoph Hellwig
2006-11-05 8:22 ` David Miller, Christoph Hellwig [this message]
2006-11-06 23:39 ` Christoph Hellwig
2006-11-07 6:25 ` Ravikiran G Thirumalai
2006-11-07 10:15 ` Christoph Hellwig
2006-11-08 2:40 ` KAMEZAWA Hiroyuki
2006-11-10 18:16 ` Christoph Lameter
2006-11-10 18:28 ` Lee Schermerhorn
2006-11-11 0:08 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061105.002237.18309940.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox