From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org
Subject: Re: Reduce CONFIG_ZONE_DMA ifdefs
Date: Tue, 17 Oct 2006 17:02:36 -0700 [thread overview]
Message-ID: <20061017170236.35dce526.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0610171123160.14002@schroedinger.engr.sgi.com>
On Tue, 17 Oct 2006 11:25:07 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:
> Add a DMA_ZONE constant that can be used to avoid #ifdef DMAs. I hope this
> will make it acceptable to remove ZONE_DMA dependent code such as the
> bouncing logic and also allow us to deal with the GFP_DMA issues in the
> SCSI layer.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>
> Index: linux-2.6.19-rc1-mm1/include/linux/mmzone.h
> ===================================================================
> --- linux-2.6.19-rc1-mm1.orig/include/linux/mmzone.h 2006-10-17 13:08:22.000000000 -0500
> +++ linux-2.6.19-rc1-mm1/include/linux/mmzone.h 2006-10-17 13:08:51.018160800 -0500
> @@ -149,6 +149,12 @@ enum zone_type {
> * match the requested limits. See gfp_zone() in include/linux/gfp.h
> */
>
> +#ifdef CONFIG_ZONE_DMA
> +#define DMA_ZONE 1
> +#else
> +#define DMA_ZONE 0
> +#endif
This can be done in the config system. See CONFIG_BASE_SMALL for an
example.
That would give the thing a nice name, too - say, CONFIG_HAVE_ZONE_DMA. It
makes it obvious what's going on.
If that doesn't work out, a better name would be HAVE_ZONE_DMA or
something. "DMA_ZONE" sounds like the number of the dma zone.
> -#ifdef CONFIG_ZONE_DMA
> -#ifdef CONFIG_ZONE_DMA
> -#ifdef CONFIG_ZONE_DMA
Only three. Drat.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-10-18 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 18:25 Christoph Lameter
2006-10-18 0:02 ` Andrew Morton [this message]
2006-10-18 0:29 ` Christoph Lameter
2006-10-23 23:06 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061017170236.35dce526.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox