From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Memory Management <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: SPAM: Re: [patch 3/3] mm: fault handler to replace nopage and populate
Date: Wed, 11 Oct 2006 02:43:33 +0200 [thread overview]
Message-ID: <20061011004333.GA25430@wotan.suse.de> (raw)
In-Reply-To: <20061010105236.2ef0268b.akpm@osdl.org>
On Tue, Oct 10, 2006 at 10:52:36AM -0700, Andrew Morton wrote:
> On Tue, 10 Oct 2006 14:13:27 +0200
> Nick Piggin <npiggin@suse.de> wrote:
> >
> > Hmm... I agree it is more consistent, but OTOH if we're passing a
> > structure I thought it may as well just go in there. But I will
> > change unless anyone comes up with an objection.
>
> I'd agree that it's more attractive to have the vma* in the argument list,
> but it presumably adds runtime cost: cycles and stack depth. I don't how
> much though.
Possibly, though I considered it might end up in a register, and
considering that the vma is used both before and after the call, and
in filemap_nopage, it's quite possible that it saves a load and does
not harm stack depth. Maybe?
I don't know, I guess we can tweak it while it is in -mm?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-10-11 0:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-07 13:05 [rfc] 2.6.19-rc1: vm stuff Nick Piggin
2006-10-07 13:05 ` [patch 1/3] mm: arch_free_page fix Nick Piggin
2006-10-07 13:05 ` [patch 2/3] mm: locks_freed fix Nick Piggin
2006-10-07 13:06 ` [patch 3/3] mm: add arch_alloc_page Nick Piggin
2006-10-07 20:43 ` Andrew Morton
2006-10-08 1:39 ` Nick Piggin
2006-10-11 14:48 ` Martin Schwidefsky
2006-10-11 14:56 ` Nick Piggin
2006-10-11 15:07 ` Martin Schwidefsky
2006-10-07 13:06 ` [patch 1/3] mm: fault vs invalidate/truncate check Nick Piggin
2006-10-07 13:06 ` [patch 2/3] mm: fault vs invalidate/truncate race fix Nick Piggin
2006-10-07 20:43 ` Andrew Morton
2006-10-07 20:44 ` Andrew Morton
2006-10-08 2:05 ` Nick Piggin
2006-10-07 13:06 ` [patch 3/3] mm: fault handler to replace nopage and populate Nick Piggin
2006-10-07 15:14 ` Jeff Garzik
2006-10-08 2:17 ` Nick Piggin
2006-10-07 20:44 ` Andrew Morton
2006-10-08 2:12 ` Nick Piggin
2006-10-08 23:46 ` Benjamin Herrenschmidt
2006-10-09 10:26 ` Nick Piggin
2006-10-09 10:50 ` Benjamin Herrenschmidt
2006-10-09 11:00 ` Nick Piggin
2006-10-09 11:10 ` Benjamin Herrenschmidt
2006-10-09 11:19 ` Nick Piggin
2006-10-09 11:32 ` Benjamin Herrenschmidt
2006-10-09 11:45 ` Nick Piggin
2006-10-09 11:49 ` Benjamin Herrenschmidt
2006-10-09 11:58 ` Nick Piggin
2006-10-09 12:07 ` Benjamin Herrenschmidt
2006-10-09 12:14 ` Nick Piggin
2006-10-09 13:38 ` Thomas Hellstrom
2006-10-09 13:52 ` Nick Piggin
2006-10-09 20:50 ` Benjamin Herrenschmidt
2006-10-10 6:11 ` Thomas Hellström
2006-10-10 7:55 ` Benjamin Herrenschmidt
2006-10-10 8:39 ` Thomas Hellstrom
2006-10-09 20:45 ` Benjamin Herrenschmidt
2006-10-09 12:09 ` Nick Piggin
2006-10-09 12:11 ` Benjamin Herrenschmidt
2006-10-10 12:10 ` Christoph Hellwig
2006-10-10 12:13 ` Nick Piggin
2006-10-10 17:52 ` Andrew Morton
2006-10-11 0:43 ` Nick Piggin [this message]
[not found] ` <5c77e7070610120456t1bdaa95cre611080c9c953582@mail.gmail.com>
2006-10-12 12:07 ` Nick Piggin
2006-10-14 13:28 ` Ingo Oeser
2006-10-15 7:54 ` Nick Piggin
2006-10-24 21:31 ` Dave Airlie
2006-10-26 11:09 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061011004333.GA25430@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox