From: Andrew Morton <akpm@osdl.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Nick Piggin <npiggin@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Memory Management List <linux-mm@kvack.org>,
Greg KH <gregkh@suse.de>
Subject: Re: [patch] mm: bug in set_page_dirty_buffers
Date: Mon, 9 Oct 2006 20:20:39 -0700 [thread overview]
Message-ID: <20061009202039.b6948a93.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0610091951350.3952@g5.osdl.org>
On Mon, 9 Oct 2006 20:06:05 -0700 (PDT)
Linus Torvalds <torvalds@osdl.org> wrote:
> On Tue, 10 Oct 2006, Nick Piggin wrote:
> >
> > This was triggered, but not the fault of, the dirty page accounting
> > patches. Suitable for -stable as well, after it goes upstream.
>
> Applied. However, I wonder what protects "page_mapping()" here?
Nothing. And I don't understand the (unchangelogged) switch from
page->mapping to page_mapping().
> I don't
> think we hold the page lock anywhere, so "page->mapping" can change at any
> time, no?
Yes. The patch makes the race window a bit smaller.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-10-10 3:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 2:36 Nick Piggin
2006-10-10 3:06 ` Linus Torvalds
2006-10-10 3:19 ` Nick Piggin
2006-10-10 3:20 ` Andrew Morton [this message]
2006-10-10 3:34 ` Nick Piggin
2006-10-10 3:50 ` Andrew Morton
2006-10-10 3:58 ` Nick Piggin
2006-10-10 4:14 ` Andrew Morton
2006-10-10 4:21 ` Nick Piggin
2006-10-10 4:38 ` Andrew Morton
2006-10-10 4:47 ` Nick Piggin
2006-10-10 5:01 ` Andrew Morton
2006-10-10 5:22 ` Nick Piggin
2006-10-10 5:29 ` Andrew Morton
2006-10-10 5:48 ` Nick Piggin
2006-10-10 6:08 ` Andrew Morton
2006-10-10 6:19 ` Nick Piggin
2006-10-10 6:27 ` Andrew Morton
2006-10-10 6:39 ` Nick Piggin
2006-10-10 6:52 ` Nick Piggin
2006-10-10 7:06 ` Andrew Morton
2006-10-10 7:21 ` Nick Piggin
2006-10-10 8:07 ` Andrew Morton
2006-10-10 8:18 ` Nick Piggin
2006-10-10 8:41 ` Andrew Morton
2006-10-10 8:49 ` Nick Piggin
2006-10-10 9:07 ` Andrew Morton
2006-10-10 9:23 ` Nick Piggin
2006-10-10 6:48 ` Peter Zijlstra
2006-10-10 6:59 ` Nick Piggin
2006-10-10 7:11 ` Peter Zijlstra
2006-10-10 7:30 ` Nick Piggin
2006-10-10 4:11 ` Nick Piggin
2006-10-10 3:37 ` Andrew Morton
2006-10-10 3:42 ` Nick Piggin
2006-10-10 7:42 ` patch mm-bug-in-set_page_dirty_buffers.patch queued to -stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009202039.b6948a93.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=a.p.zijlstra@chello.nl \
--cc=gregkh@suse.de \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox