From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 7 Oct 2006 13:44:01 -0700 From: Andrew Morton Subject: Re: [patch 2/3] mm: fault vs invalidate/truncate race fix Message-Id: <20061007134401.a28b7735.akpm@osdl.org> In-Reply-To: <20061007105842.14024.85533.sendpatchset@linux.site> References: <20061007105758.14024.70048.sendpatchset@linux.site> <20061007105842.14024.85533.sendpatchset@linux.site> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Linux Memory Management , Linux Kernel List-ID: On Sat, 7 Oct 2006 15:06:21 +0200 (CEST) Nick Piggin wrote: > Fix the race between invalidate_inode_pages and do_no_page. - In do_no_page() there's a `goto retry' where we appear to have forgotten to (conditionally) unlock the page. - In do_no_page() the COW-break code seem to have forgotten to (conditionally) unlock the page which it just COWed? - In do_no_page(), the unlock_page() which _is_ there doesn't test VM_CAN_INVALIDATE before deciding to unlock the page. I have a bad feeling that I'm not getting the point here... Ah, it appears you've fixed at least some of these things in the next patch. Tricky. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org