From: Randy Dunlap <rdunlap@xenotime.net>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Christoph Lameter <clameter@sgi.com>,
linux-mm@kvack.org, akpm <akpm@osdl.org>
Subject: Re: [PATCH v2] page_alloc: fix kernel-doc and func. declaration
Date: Wed, 4 Oct 2006 08:14:54 -0700 [thread overview]
Message-ID: <20061004081454.60ab4a66.rdunlap@xenotime.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0610041115270.21730@skynet.skynet.ie>
On Wed, 4 Oct 2006 11:26:31 +0100 (IST) Mel Gorman wrote:
> On Tue, 3 Oct 2006, Randy Dunlap wrote:
>
> > /**
> > * free_bootmem_with_active_regions - Call free_bootmem_node for each active range
> > - * @nid: The node to free memory on. If MAX_NUMNODES, all nodes are freed
> > - * @max_low_pfn: The highest PFN that till be passed to free_bootmem_node
> > + * @nid: The node to free memory on. If MAX_NUMNODES, all nodes are freed.
> > + * @max_low_pfn: The highest PFN that will be passed to free_bootmem_node
>
> Should @max_low_pfn have a '.' at the end?
I didn't add one since it's not a complete sentence.
> > *
> > * If an architecture guarantees that all ranges registered with
> > * add_active_ranges() contain no holes and may be freed, this
> > @@ -2582,11 +2582,12 @@ void __init shrink_active_range(unsigned
> >
> > /**
> > * remove_all_active_ranges - Remove all currently registered regions
> > + *
>
> For future reference, I am going to assume the newline is required between
> the arguement list and the long description.
Yes, thanks.
> > * During discovery, it may be found that a table like SRAT is invalid
> > * and an alternative discovery method must be used. This function removes
> > * all currently registered regions.
> > */
---
~Randy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-10-04 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 21:14 [PATCH] " Randy Dunlap, Randy Dunlap
2006-10-03 21:36 ` Christoph Lameter
2006-10-03 22:49 ` Randy Dunlap
2006-10-03 23:05 ` Christoph Lameter
2006-10-03 23:17 ` [PATCH v2] " Randy Dunlap
2006-10-04 10:26 ` Mel Gorman
2006-10-04 15:14 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061004081454.60ab4a66.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox