linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org, akpm <akpm@osdl.org>
Subject: Re: [PATCH] page_alloc: fix kernel-doc and func. declaration
Date: Tue, 3 Oct 2006 15:49:49 -0700	[thread overview]
Message-ID: <20061003154949.7953c6f9.rdunlap@xenotime.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0610031435590.22775@schroedinger.engr.sgi.com>

On Tue, 3 Oct 2006 14:36:58 -0700 (PDT) Christoph Lameter wrote:

> On Tue, 3 Oct 2006, Randy Dunlap wrote:
> 
> >  /**
> >   * set_dma_reserve - Account the specified number of pages reserved in ZONE_DMA
> > - * @new_dma_reserve - The number of pages to mark reserved
> > + * @new_dma_reserve: The number of pages to mark reserved
> >   *
> >   * The per-cpu batchsize and zone watermarks are determined by present_pages.
> >   * In the DMA zone, a significant percentage may be consumed by kernel image
> >   * and other unfreeable allocations which can skew the watermarks badly. This
> >   * function may optionally be used to account for unfreeable pages in
> > - * ZONE_DMA. The effect will be lower watermarks and smaller per-cpu batchsize
> > + * ZONE_DMA. The effect will be lower watermarks and smaller per-cpu batchsize.
> >   */
> >  void __init set_dma_reserve(unsigned long new_dma_reserve)
> 
> Hmmm. With the optional ZONE_DMA patch this becomes a reservation in the 
> first zone, which may be ZONE_NORMAL.

I didn't change any of that wording.  Do you want to change it?
do you want me to make that change?  or what?

thanks,
---
~Randy

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-10-03 22:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-03 21:14 Randy Dunlap, Randy Dunlap
2006-10-03 21:36 ` Christoph Lameter
2006-10-03 22:49   ` Randy Dunlap [this message]
2006-10-03 23:05     ` Christoph Lameter
2006-10-03 23:17       ` [PATCH v2] " Randy Dunlap
2006-10-04 10:26         ` Mel Gorman
2006-10-04 15:14           ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061003154949.7953c6f9.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox