From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 28 Sep 2006 09:40:23 -0700 From: Andrew Morton Subject: Re: Checking page_count(page) in invalidate_complete_page Message-Id: <20060928094023.e888d533.akpm@osdl.org> In-Reply-To: <20060928093640.14ecb1b1.akpm@osdl.org> References: <4518333E.2060101@oracle.com> <20060925141036.73f1e2b3.akpm@osdl.org> <45185D7E.6070104@yahoo.com.au> <451862C5.1010900@oracle.com> <45186481.1090306@yahoo.com.au> <45186DC3.7000902@oracle.com> <451870C6.6050008@yahoo.com.au> <4518835D.3080702@oracle.com> <451886FB.50306@yahoo.com.au> <451BF7BC.1040807@oracle.com> <20060928093640.14ecb1b1.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: chuck.lever@oracle.com, Nick Piggin , Trond Myklebust , Steve Dickson , linux-mm@kvack.org List-ID: On Thu, 28 Sep 2006 09:36:40 -0700 Andrew Morton wrote: > > I think a call to lru_add_drain_all() belongs in both the > > invalidate_inode_pages() and the invalidate_inode_pages2() path. Do you > > agree? > > Yes. Or maybe not. lru_add_drain() will only drain the local CPU's buffer. If the page is sitting in another CPU's buffer, the same problem will occur. IOW, you got lucky. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org