From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 15 Sep 2006 21:34:09 -0700 From: Andrew Morton Subject: Re: [PATCH] GFP_THISNODE for the slab allocator Message-Id: <20060915213409.925c8cdc.akpm@osdl.org> In-Reply-To: References: <20060914220011.2be9100a.akpm@osdl.org> <20060914234926.9b58fd77.pj@sgi.com> <20060915002325.bffe27d1.akpm@osdl.org> <20060915004402.88d462ff.pj@sgi.com> <20060915010622.0e3539d2.akpm@osdl.org> <20060915170455.f8b98784.pj@sgi.com> <20060915183604.11a8d045.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Paul Jackson , David Rientjes , linux-mm@kvack.org List-ID: On Fri, 15 Sep 2006 19:23:43 -0700 (PDT) Christoph Lameter wrote: > On Fri, 15 Sep 2006, Andrew Morton wrote: > > > I doubt it - if we still hit z->zone_pgdat->node_id for all 40-odd zones, > > I expect the cost will be comparable. > > This is the zone_to_nid() macro. > > Could we add a node_id field to the zone? So zone_to_nid() becomes one > lookup? > > Note that zone_pgdat is out of the hot zone in the zone structure. Its > therefore slow. Guys, it's still 50 cachelines per page. This one needs more than tweaking - algorithmic changes are needed. Is there something wrong with caching the most-recent-zone? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org