From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 25 Aug 2006 17:48:32 -0700 From: Andrew Morton Subject: Re: zone_reclaim: dynamic zone based slab reclaim Message-Id: <20060825174832.767af9e8.akpm@osdl.org> In-Reply-To: References: <20060825164233.8276e425.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: npiggin@suse.de, linux-mm@kvack.org List-ID: On Fri, 25 Aug 2006 17:27:42 -0700 (PDT) Christoph Lameter wrote: > On Fri, 25 Aug 2006, Andrew Morton wrote: > > > On Fri, 25 Aug 2006 15:22:14 -0700 (PDT) > > Christoph Lameter wrote: > > > > > > This patch implements slab reclaim during zone reclaim. > > > > hrm, OK. Yes, the globalness of the slab is a bit sad. > > > > > unsigned long min_unmapped_ratio; > > > + unsigned long min_slab_ratio; > > > > These are not ratios. Can we please rename them? min_unmapped_page_count? > > Yes I was wondering about that when you introduced it. Should've thwapped me. > How about simply removing the _ratio at the end? > > min_unmapped > min_slab It's nice to have the units in the identifier. min_unmapped_pages? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org