From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: npiggin@suse.de, linux-mm@kvack.org
Subject: Re: zone_reclaim: dynamic zone based slab reclaim
Date: Fri, 25 Aug 2006 17:48:32 -0700 [thread overview]
Message-ID: <20060825174832.767af9e8.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0608251727010.11715@schroedinger.engr.sgi.com>
On Fri, 25 Aug 2006 17:27:42 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:
> On Fri, 25 Aug 2006, Andrew Morton wrote:
>
> > On Fri, 25 Aug 2006 15:22:14 -0700 (PDT)
> > Christoph Lameter <clameter@sgi.com> wrote:
> > >
> > > This patch implements slab reclaim during zone reclaim.
> >
> > hrm, OK. Yes, the globalness of the slab is a bit sad.
> >
> > > unsigned long min_unmapped_ratio;
> > > + unsigned long min_slab_ratio;
> >
> > These are not ratios. Can we please rename them? min_unmapped_page_count?
>
> Yes I was wondering about that when you introduced it.
Should've thwapped me.
> How about simply removing the _ratio at the end?
>
> min_unmapped
> min_slab
It's nice to have the units in the identifier. min_unmapped_pages?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-08-26 0:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 22:16 ZVC: Support NR_SLAB_RECLAIM Christoph Lameter
2006-08-25 22:22 ` zone_reclaim: dynamic zone based slab reclaim Christoph Lameter
2006-08-25 23:42 ` Andrew Morton
2006-08-26 0:27 ` Christoph Lameter
2006-08-26 0:48 ` Andrew Morton [this message]
2006-08-25 23:56 ` ZVC: Support NR_SLAB_RECLAIM Andrew Morton
2006-08-26 0:30 ` Christoph Lameter
2006-08-26 0:55 ` Andrew Morton
2006-08-26 0:58 ` Christoph Lameter
2006-08-26 1:07 ` Andrew Morton
2006-08-26 1:10 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060825174832.767af9e8.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox