From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Fri, 25 Aug 2006 17:38:01 +0200 Message-Id: <20060825153801.24254.34847.sendpatchset@twins> In-Reply-To: <20060825153709.24254.28118.sendpatchset@twins> References: <20060825153709.24254.28118.sendpatchset@twins> Subject: [PATCH 5/6] nfs: Add comment on PG_private use of NFS Sender: owner-linux-mm@kvack.org Return-Path: To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Rik van Riel , Peter Zijlstra , Andrew Morton , Trond Myklebust List-ID: Add a comment explaining the use of PG_private in the NFS client. Signed-off-by: Peter Zijlstra --- fs/nfs/write.c | 5 +++++ 1 file changed, 5 insertions(+) Index: linux-2.6/fs/nfs/write.c =================================================================== --- linux-2.6.orig/fs/nfs/write.c +++ linux-2.6/fs/nfs/write.c @@ -424,6 +424,11 @@ static int nfs_inode_add_request(struct if (nfs_have_delegation(inode, FMODE_WRITE)) nfsi->change_attr++; } + /* + * The PG_private bit is unfortunately needed if we want to fix the + * hole in the mmap semantics. If we do not set it, then the VM will + * fail to call the "releasepage" address ops. + */ SetPagePrivate(req->wb_page); nfsi->npages++; atomic_inc(&req->wb_count); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org