From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@osdl.org, linux-mm@kvack.org,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: Re: Apply type enum zone_type
Date: Sat, 5 Aug 2006 03:38:47 +0200 [thread overview]
Message-ID: <200608050338.47642.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0608041654380.5573@schroedinger.engr.sgi.com>
On Saturday 05 August 2006 01:55, Christoph Lameter wrote:
> After we have done this we can now do some typing cleanup.
>
> The memory policy layer keeps a policy_zone that specifies
> the zone that gets memory policies applied. This variable
> can now be of type enum zone_type.
>
> The check_highest_zone function and the build_zonelists funnctionm must
> then also take a enum zone_type parameter.
>
> Plus there are a number of loops over zones that also should use
> zone_type.
>
> We run into some troubles at some points with functions that need a
> zone_type variable to become -1. Fix that up.
enums are not really type checked, so it seems somewhat pointless
to do this change.
If you really wanted strict type checking you would need typedef struct
and accessors.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-08-05 1:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-04 23:54 mempolicies: fix policy_zone check Christoph Lameter
2006-08-04 23:55 ` Apply type enum zone_type Christoph Lameter
2006-08-04 23:57 ` linearly index zone->node_zonelists[] Christoph Lameter
2006-08-05 1:50 ` Andi Kleen
2006-08-08 12:20 ` Andy Whitcroft
2006-08-08 15:50 ` Christoph Lameter
2006-08-05 1:38 ` Andi Kleen [this message]
2006-08-05 2:01 ` Apply type enum zone_type Christoph Lameter
2006-08-05 0:08 ` mempolicies: fix policy_zone check Andrew Morton
2006-08-05 0:18 ` Christoph Lameter
2006-08-07 13:40 ` Lee Schermerhorn
2006-08-05 1:49 ` Andi Kleen
2006-08-05 2:05 ` Christoph Lameter
2006-08-08 12:00 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608050338.47642.ak@suse.de \
--to=ak@suse.de \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox