From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <npiggin@suse.de>,
Linux Memory Management <linux-mm@kvack.org>
Subject: [patch 3/9] cpuset: oom panic fix
Date: Fri, 28 Jul 2006 09:21:11 +0200 (CEST) [thread overview]
Message-ID: <20060515210556.30275.63352.sendpatchset@linux.site> (raw)
In-Reply-To: <20060515210529.30275.74992.sendpatchset@linux.site>
cpuset_excl_nodes_overlap always returns 0 if current is exiting. This caused
customer's systems to panic in the OOM killer when processes were having
trouble getting memory for the final put_user in mm_release. Even though there
were lots of processes to kill.
Change to returning 0 in this case. This achieves parity with !CONFIG_CPUSETS
case, and was observed to fix the problem.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Index: linux-2.6/kernel/cpuset.c
===================================================================
--- linux-2.6.orig/kernel/cpuset.c
+++ linux-2.6/kernel/cpuset.c
@@ -2369,7 +2369,7 @@ EXPORT_SYMBOL_GPL(cpuset_mem_spread_node
int cpuset_excl_nodes_overlap(const struct task_struct *p)
{
const struct cpuset *cs1, *cs2; /* my and p's cpuset ancestors */
- int overlap = 0; /* do cpusets overlap? */
+ int overlap = 1; /* do cpusets overlap? */
task_lock(current);
if (current->flags & PF_EXITING) {
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-07-28 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 7:20 [patch 0/9] oom: various fixes and improvements for 2.6.18-rc2 Nick Piggin
2006-07-28 7:20 ` [patch 1/9] oom: use unreclaimable info Nick Piggin
2006-07-28 7:21 ` [patch 2/9] oom: reclaim_mapped on oom Nick Piggin
2006-07-28 7:21 ` Nick Piggin [this message]
2006-07-28 7:29 ` [patch 3/9] cpuset: oom panic fix Nick Piggin
2006-07-28 9:06 ` Paul Jackson
2006-07-28 7:21 ` [patch 4/9] oom: cpuset hint Nick Piggin
2006-07-28 9:07 ` Paul Jackson
2006-07-28 7:21 ` [patch 5/9] oom: handle current exiting Nick Piggin
2006-07-28 7:21 ` [patch 6/9] oom: handle oom_disable exiting Nick Piggin
2006-07-28 7:21 ` [patch 7/9] oom: swapoff tasks tweak Nick Piggin
2006-07-28 7:21 ` [patch 8/9] oom: kthread infinite loop fix Nick Piggin
2006-07-28 7:22 ` [patch 9/9] oom: more printk Nick Piggin
2006-07-28 7:44 ` [patch 0/9] oom: various fixes and improvements for 2.6.18-rc2 Andrew Morton
2006-07-28 9:28 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060515210556.30275.63352.sendpatchset@linux.site \
--to=npiggin@suse.de \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox