From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 4 May 2006 21:25:28 +0200 From: Ingo Molnar Subject: Re: assert/crash in __rmqueue() when enabling CONFIG_NUMA Message-ID: <20060504192528.GA26759@elte.hu> References: <20060419112130.GA22648@elte.hu> <20060502070618.GA10749@elte.hu> <200605020905.29400.ak@suse.de> <44576688.6050607@mbligh.org> <44576BF5.8070903@yahoo.com.au> <20060504013239.GG19859@localhost> <1146756066.22503.17.camel@localhost.localdomain> <20060504154652.GA4530@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060504154652.GA4530@localhost> Sender: owner-linux-mm@kvack.org Return-Path: To: Bob Picco Cc: Dave Hansen , Nick Piggin , "Martin J. Bligh" , Andi Kleen , linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management , Andy Whitcroft List-ID: * Bob Picco wrote: > Dave Hansen wrote: [Thu May 04 2006, 11:21:06AM EDT] > > I haven't thought through it completely, but these two lines worry me: > > > > > + start = pgdat->node_start_pfn & ~((1 << (MAX_ORDER - 1)) - 1); > > > + end = start + pgdat->node_spanned_pages; > > > > Should the "end" be based off of the original "start", or the aligned > > "start"? > > Yes. I failed to quilt refresh before sending. You mean end should be > end = pgdat->node_start_pfn + pgdat->node_spanned_pages before > rounding up. do you have an updated patch i should try? Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org