Re: [PATCH 5/7] page migration: synchronize from and to lists

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Thu, 27 Apr 2006 23:03:23 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:

> page migration: synchronize from and to lists to migrate_pages()
> 
> Handle pages from the "from" and "to" lists in such a way that the nth page
> from "from" is moved to the nth page from "to". That way page placement
> for each page can be controlled separately.
> 
It looks this path is not treated in desired way.
==
		rc=0;
                if (page_count(page) == 1)
                        /* page was freed from under us. So we are done. */
                        goto next;
next:
                if (rc) {
			<snip>;
		} else {
			 if (newpage) <--- new page is NULL. here
                                /* Successful migration. Return page to LRU */
                                move_to_lru(newpage);

                        list_move(&page->lru, moved);
                }
==

you should rotate "to" list in this case, I think.		

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>