From: Andi Kleen <ak@suse.de>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-mm@kvack.org, akpm@osdl.org, frankeh@watson.ibm.com,
rhim@cc.gatech.edu
Subject: Re: [patch 1/8] Page host virtual assist: unused / free pages.
Date: Mon, 24 Apr 2006 16:07:14 +0200 [thread overview]
Message-ID: <200604241607.15131.ak@suse.de> (raw)
In-Reply-To: <20060424123423.GB15817@skybase>
On Monday 24 April 2006 14:34, Martin Schwidefsky wrote:
> +#define page_hva_set_unused(_page) do { } while (0)
> +#define page_hva_set_stable(_page) do { } while (0)
The whole thing seems quite under commented in the code and illnamed
(if you didn't know what page_hva_set_unused() is supposed to do
already would you figure it out from the name?)
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-04-24 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 12:34 Martin Schwidefsky, Martin Schwidefsky, Hubertus Franke, Himanshu Raj
2006-04-24 14:07 ` Andi Kleen [this message]
2006-04-24 14:41 ` Martin Schwidefsky
2006-04-24 14:49 ` Andi Kleen
2006-04-24 14:59 ` Martin Schwidefsky
2006-04-24 15:06 ` Andi Kleen
2006-04-24 15:43 ` Hubertus Franke
2006-04-25 12:20 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604241607.15131.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=frankeh@watson.ibm.com \
--cc=linux-mm@kvack.org \
--cc=rhim@cc.gatech.edu \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox