From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 14 Apr 2006 11:44:37 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 5/5] Swapless V2: Revise main migration logic Message-Id: <20060414114437.1a5a9c7c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20060414113455.15fd5162.kamezawa.hiroyu@jp.fujitsu.com> References: <20060413235406.15398.42233.sendpatchset@schroedinger.engr.sgi.com> <20060413235432.15398.23912.sendpatchset@schroedinger.engr.sgi.com> <20060414101959.d59ac82d.kamezawa.hiroyu@jp.fujitsu.com> <20060414113455.15fd5162.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: clameter@sgi.com, akpm@osdl.org, hugh@veritas.com, linux-kernel@vger.kernel.org, lee.schermerhorn@hp.com, linux-mm@kvack.org, taka@valinux.co.jp, marcelo.tosatti@cyclades.com List-ID: soryy...This is wrong. On Fri, 14 Apr 2006 11:34:55 +0900 KAMEZAWA Hiroyuki wrote: > /* Use last entry for page migration swap entries */ > -#define MAX_SWAPFILES ((1 << MAX_SWAPFILES_SHIFT)-1) > -#define SWP_TYPE_MIGRATION MAX_SWAPFILES > +#define MAX_SWAPFILES ((1 << MAX_SWAPFILES_SHIFT)-2) > +/* write protected page under migration*/ > +#define SWP_TYPE_MIGRATION_WP (MAX_SWAPFILES - 1) > +/* write enabled migration type */ > +#define SWP_TYPE_MIGRATION_WE (MAX_SWAPFILES) > #endif maybe I need one more eye.. This is fix. -Kame Index: Christoph-New-Migration/include/linux/swap.h =================================================================== --- Christoph-New-Migration.orig/include/linux/swap.h 2006-04-14 11:13:55.000000000 +0900 +++ Christoph-New-Migration/include/linux/swap.h 2006-04-14 11:40:28.000000000 +0900 @@ -35,9 +35,9 @@ /* Use last entry for page migration swap entries */ #define MAX_SWAPFILES ((1 << MAX_SWAPFILES_SHIFT)-2) /* write protected page under migration*/ -#define SWP_TYPE_MIGRATION_WP (MAX_SWAPFILES - 1) +#define SWP_TYPE_MIGRATION_WP (MAX_SWAPFILES) /* write enabled migration type */ -#define SWP_TYPE_MIGRATION_WE (MAX_SWAPFILES) +#define SWP_TYPE_MIGRATION_WE (MAX_SWAPFILES + 1) #endif /* -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org