From: mel@csn.ul.ie (Mel Gorman)
To: "Luck, Tony" <tony.luck@intel.com>
Cc: davej@codemonkey.org.uk, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, bob.picco@hp.com, ak@suse.de,
linux-mm@kvack.org
Subject: Re: [PATCH 0/7] [RFC] Sizing zones and holes in an architecture independent manner V2
Date: Thu, 13 Apr 2006 18:30:08 +0100 [thread overview]
Message-ID: <20060413173008.GA19402@skynet.ie> (raw)
In-Reply-To: <20060413171942.GA15047@agluck-lia64.sc.intel.com>
On (13/04/06 10:19), Luck, Tony didst pronounce:
> On Thu, Apr 13, 2006 at 10:52:08AM +0100, Mel Gorman wrote:
> > I didn't look at the test program output carefully enough! There was a
> > double counting of some holes because of a missing "if" - obvious in the
> > morning. Fix is this (applies on top of the debugging patch)
>
> Back to not booting with tiger_defconfig on Intel Tiger box :-(
>
> There are no lines like:
>
> On node 0 totalpages: 260725
> DMA zone: 129700 pages, LIFO batch:7
> Normal zone: 131025 pages, LIFO batch:7
>
> in the log ... which might explain the OOM later.
>
> Whole console log appended (The "Kill process 2" messages repeat
> forever).
>
> -Tony
>
>
> <SNIP>
> Dumping sorted node map
> entry 0: 0 1024 -> 130688
> entry 1: 0 130984 -> 131020
> entry 2: 0 393216 -> 524164
> entry 3: 0 524192 -> 524269
> Hole found index 1: 130688 -> 130984
> Hole found index 2: 131020 -> 262144
> Hole found index 2: 131020 -> 393216
Double counted a hole here, then went downhill. Does the following fix
it?
diff -rup -X /usr/src/patchset-0.5/bin//dontdiff linux-2.6.17-rc1-zonesizing-v6/mm/mem_init.c linux-2.6.17-rc1-107-debug/mm/mem_init.c
--- linux-2.6.17-rc1-zonesizing-v6/mm/mem_init.c 2006-04-13 10:30:50.000000000 +0100
+++ linux-2.6.17-rc1-107-debug/mm/mem_init.c 2006-04-13 18:00:39.000000000 +0100
@@ -753,17 +753,21 @@ unsigned long __init zone_absent_pages_i
start_pfn = early_node_map[i].start_pfn;
if (start_pfn > arch_zone_highest_possible_pfn[zone_type])
start_pfn = arch_zone_highest_possible_pfn[zone_type];
- if (prev_end_pfn > start_pfn) {
- printk("prev_end > start_pfn : %lu > %lu\n",
- prev_end_pfn,
- start_pfn);
- BUG();
- }
+ if (prev_end_pfn < arch_zone_lowest_possible_pfn[zone_type])
+ prev_end_pfn = arch_zone_lowest_possible_pfn[zone_type];
/* Update the hole size cound and move on */
- hole_pages += start_pfn - prev_end_pfn;
- printk("Hole found index %d: %lu -> %lu\n",
- i, prev_end_pfn, start_pfn);
+ if (start_pfn > arch_zone_lowest_possible_pfn[zone_type]) {
+ if (prev_end_pfn > start_pfn) {
+ printk("prev_end > start_pfn : %lu > %lu\n",
+ prev_end_pfn,
+ start_pfn);
+ BUG();
+ }
+ hole_pages += start_pfn - prev_end_pfn;
+ printk("Hole found index %d: %lu -> %lu\n",
+ i, prev_end_pfn, start_pfn);
+ }
prev_end_pfn = early_node_map[i].end_pfn;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-04-13 17:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 23:20 Mel Gorman
2006-04-12 23:20 ` [PATCH 1/7] Introduce mechanism for registering active regions of memory Mel Gorman
2006-04-12 23:21 ` [PATCH 2/7] Have Power use add_active_range() and free_area_init_nodes() Mel Gorman
2006-04-12 23:21 ` [PATCH 3/7] Have x86 use add_active_range() and free_area_init_nodes Mel Gorman
2006-04-12 23:21 ` [PATCH 4/7] Have x86_64 " Mel Gorman
2006-04-12 23:22 ` [PATCH 5/7] Have ia64 " Mel Gorman
2006-04-12 23:22 ` [PATCH 6/7] Break out memory initialisation code from page_alloc.c to mem_init.c Mel Gorman
2006-04-12 23:22 ` [PATCH 7/7] Print out debugging information during initialisation Mel Gorman
2006-04-12 23:53 ` [PATCH 0/7] [RFC] Sizing zones and holes in an architecture independent manner V2 Andi Kleen
2006-04-13 0:22 ` Mel Gorman
2006-04-13 0:56 ` Andi Kleen
2006-04-13 1:08 ` Dave Hansen
2006-04-13 10:24 ` Mel Gorman
2006-04-13 9:52 ` Mel Gorman
2006-04-13 10:32 ` Yasunori Goto
2006-04-13 10:51 ` Mel Gorman
2006-04-13 17:19 ` Luck, Tony
2006-04-13 17:30 ` Mel Gorman [this message]
2006-04-13 17:47 ` Luck, Tony
2006-04-13 19:14 ` Mel Gorman
2006-04-13 21:53 ` Luck, Tony
2006-04-14 13:12 ` Mel Gorman
2006-04-14 20:53 ` Luck, Tony
2006-04-14 22:54 ` Mel Gorman
2006-04-14 23:17 ` Nigel Cunningham
2006-04-14 23:50 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060413173008.GA19402@skynet.ie \
--to=mel@csn.ul.ie \
--cc=ak@suse.de \
--cc=bob.picco@hp.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox