From: Con Kolivas <kernel@kolivas.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux list <linux-kernel@vger.kernel.org>,
ck list <ck@vds.kolivas.org>, Andrew Morton <akpm@osdl.org>,
Pavel Machek <pavel@ucw.cz>,
linux-mm@kvack.org
Subject: Re: [PATCH] swswsup: return correct load_image error
Date: Fri, 24 Mar 2006 16:17:23 +1100 [thread overview]
Message-ID: <200603241617.24434.kernel@kolivas.org> (raw)
In-Reply-To: <200603241600.56144.kernel@kolivas.org>
> On Tuesday 21 March 2006 10:22, Rafael J. Wysocki wrote:
> > Basically, yes. swsusp.c and snapshot.c contain common functions,
> > disk.c and swap.c contain the code used by the built-in swsusp only,
> > and user.c contains the userland interface. If you want something to
> > be run by the built-in swsusp only, place it in disk.c.
Would this patch suffice?
Cheers,
Con
---
Swsusp reclaims a lot of memory during the suspend cycle and can benefit
from the aggressive_swap_prefetch mode immediately upon resuming.
Signed-off-by: Con Kolivas <kernel@kolivas.org>
---
kernel/power/disk.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6.16-mm1/kernel/power/disk.c
===================================================================
--- linux-2.6.16-mm1.orig/kernel/power/disk.c 2006-03-24 15:48:14.000000000 +1100
+++ linux-2.6.16-mm1/kernel/power/disk.c 2006-03-24 16:15:05.000000000 +1100
@@ -19,6 +19,7 @@
#include <linux/fs.h>
#include <linux/mount.h>
#include <linux/pm.h>
+#include <linux/swap-prefetch.h>
#include "power.h"
@@ -138,8 +139,10 @@ int pm_suspend_disk(void)
unprepare_processes();
return error;
}
- } else
+ } else {
pr_debug("PM: Image restored successfully.\n");
+ aggressive_swap_prefetch();
+ }
swsusp_free();
Done:
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-03-24 5:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 15:34 [PATCH][3/3] mm: swsusp post resume aggressive swap prefetch Con Kolivas
2006-03-20 21:47 ` Rafael J. Wysocki
2006-03-20 21:25 ` kernel
2006-03-20 23:22 ` Rafael J. Wysocki
2006-03-21 0:44 ` kernel
2006-03-21 18:11 ` Rafael J. Wysocki
2006-03-22 6:11 ` Con Kolivas
2006-03-24 5:00 ` [PATCH] swswsup: return correct load_image error Con Kolivas
2006-03-24 5:17 ` Con Kolivas [this message]
2006-03-24 15:05 ` Rafael J. Wysocki
2006-03-24 14:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603241617.24434.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox