From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH: 003/017]Memory hotplug for new nodes v.4.(get node id at probe memory) Date: Wed, 22 Mar 2006 14:17:55 +0100 References: <20060317162835.C63D.Y-GOTO@jp.fujitsu.com> In-Reply-To: <20060317162835.C63D.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603221417.55462.ak@suse.de> Sender: owner-linux-mm@kvack.org Return-Path: To: Yasunori Goto Cc: Andrew Morton , "Luck, Tony" , Linux Kernel ML , linux-ia64@vger.kernel.org, linux-mm List-ID: On Friday 17 March 2006 09:20, Yasunori Goto wrote: > When CONFIG_NUMA && CONFIG_ARCH_MEMORY_PROBE, nid should be defined > before calling add_memory(nid, start, size). Seems a bit weird to have the node number assignment somewhere hidden in memory hotadd. It would be probably cleaner to have a separate step for this. > +#if defined(CONFIG_NUMA) && defined(CONFIG_ARCH_MEMORY_PROBE) > +extern int arch_nid_probe(u64 start); Instead of adding such ugly ifdefs better just add stubs to all the architectures that support memory hotplug. There are not that many anyways. -Andi > +#else > +static inline int arch_nid_probe(u64 start) > +{ > + return 0; > +} > +#endif > + -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org