Re: [PATCH: 017/017]Memory hotplug for new nodes v.4.(arch_register_node() for ia64)

[Yasunori Goto <y-goto@jp.fujitsu.com>]

> On Fri, 2006-03-17 at 17:23 +0900, Yasunori Goto wrote:
> > +++ pgdat8/arch/ia64/kernel/topology.c	2006-03-16 16:06:27.000000000 +0900
> > @@ -65,6 +65,21 @@ EXPORT_SYMBOL(arch_register_cpu);
> >  EXPORT_SYMBOL(arch_unregister_cpu);
> >  #endif /*CONFIG_HOTPLUG_CPU*/
> >  
> > +#ifdef CONFIG_NUMA
> > +int arch_register_node(int num)
> > +{
> > +	if (sysfs_nodes[num].sysdev.id == num)
> > +		return 0;
> > +
> > +	return register_node(&sysfs_nodes[num], num, 0);
> > +}
> > +
> > +void arch_unregister_node(int num)
> > +{
> > +	unregister_node(&sysfs_nodes[num]);
> > +	sysfs_nodes[num].sysdev.id = -1;
> > +}
> > +#endif
> 
> I don't have a real problem with you cluttering up ia64 code, but if
> these are useful, why don't we put them in generic code?  They seem
> quite arch-independent to me.

I'm not sure they can be common code.

Current i386's code treats "parent node" in arch_register_node(). 
But, IA64 doesn't need it.

Bye.

-- 
Yasunori Goto 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>